ghooks not found!

[HackPoint]

I'm receiving this even when I installed everything even globally.

ghooks not found! Make sure you have it installed on your "node_modules". Skipping git hooks.

package.json
"config": {
    "ghooks": {
      "commit-msg": "validate-commit-msg",
      "post-merge": "npm install"
    }
  }

[kentcdodds]

You definitely don't want to install this globally. Maybe if there's a way to detect this we could throw a helpful error indicating that.

Could you give us more information? Dig a little bit to try and see what's going on?

[ta2edchimp]

ghooks should have worked when installed globally, prior to version 1.2.0 (released some hours ago).
The way its core functionality is included now, supports being used from within git submodules and when altering the paths' structure by using git worktrees (as both of these ways heavily change the relation of the hooks' path to their git repo's files); but the downside is, there's no simple require('ghooks') anymore in the hooks themselves (that one provided a fallback to a globally installed ghooks, when not installed locally).

What I propose is one of the following:

• Generally npm install things like ghooks locally. npm i -D ghooks would do this as a development dependency for a particular package.

or

• Use ghooks version 1.1.1 when you don't want to install it locally to your package (or even 1.0.3 if you don't like it to exit with an error when ghooks have not been found).

---

@kentcdodds I'd happily make another PR with a fallback, trying to require a globally installed ghooks, while printing an info that it's considered best practice to install it locally. (I also have another unfinished change that would allow to configure whether or not to exit with an error if ghooks has not been found.)
And btw. sorry for adding so much noise to this project 😞

[HackPoint]

I actually tried to install it locally with '''git i -D''' still the same result. Tried latest and 1.0.2v

[ta2edchimp]

I guess you mean npm i -D ... on what version of node and npm are you testing?

[ta2edchimp]

Do you have this particular project publicly online, here on github for example?

[gtramontina]

@HackPoint, could you please paste us the result of running the following in the root of your project?

npm -v; node -v; npm ls | grep ghooks

---

@ta2edchimp:

And btw. sorry for adding so much noise to this project

Please, don't stop! Your contributions are really valuable! 👍🍻

[HackPoint]

npm -v; node -v; npm ls | grep ghooks

3.8.5
v5.7.1
+-- ghooks@1.0.3

It was after testing the whole range of versions

[ta2edchimp]

That's totally strange. Using ghooks@1.0.3 it should work even when installed globally.

• Are you using git submodules or different worktrees?
• On what git --version are you?
• What operating system are you on?
• Could you please, in a different, completely empty directory, try the following:
  • git init
  • npm init -y
  • npm i -D ghooks
  • add a pre-commit hook to package.json, sth simple like echo \"SOMETHING\"
  • make a test commit, and report if it worked?

[HackPoint]

Git version
$ git --version
git version 2.7.2

Ok, I will try to run it without anything in the project, I will update you about the progress.
Tell me could I print the Exception stack why this could happen, if ###yes### tell me where and how to run it?

[ta2edchimp]

On 1.2.0 it's not really an Exception that would bubble up, but rather a failing/rejected Promise internally. It's an Exception prior to 1.2.0 that gets catched at the very beginning of the git hook's file.

ghooks < 1.2.0
You could just comment out the try/catch line for example in .git/hooks/pre-commit and make a test commit. The stack trace should be printed to command line.

ghooks @ 1.2.0
You could use devtool to run it using a Chrome-like dev tools / inspector, it's what I'd do in this case. If you do this, change the first line of the git hook's file to be tested to read #!/usr/bin/env devtool instead of node. After that you should get an output in devtool's console that you can expand to see where it's failing originally, just like an ordinary exception in a browser's dev tools.

[ta2edchimp]

What os are you on?

[HackPoint]

El Capitan 10.11.3

[ta2edchimp]

@HackPoint do you have a project publicly available where we/I may take a look into this issue? I wasn't yet able to reproduce this -- that is, except when liberatley removing ghooks from node_modules.

[Prophet32j]

+1 for this. We are also experiencing this same issue.Also installed locally in devDependencies.
package.json

"ghooks": "^1.2.3"
"config": {
    "ghooks": {
       "pre-commit": "npm run lint",
       "pre-push": "npm test"
    }
}

[Prophet32j]

@ta2edchimp is there a requirement that the .git/ folder be on the same level as the node_modules/ folder?
Reason I ask is we have our UI project embedded in our web app project. It's not a submodule. It sits a level below the root project folder where .git/ lives. Would that cause an error?