fix: Don't exit with non-zero code on error#80
Merged
kentcdodds merged 1 commit intoghooks-org:masterfrom Apr 12, 2016
Merged
Conversation
ta2edchimp
force-pushed
the
pr/no-error-on-exit
branch
from
0e47510 to
e7bf09c
Compare
Collaborator
Author
|
@gtramontina @kentcdodds if one of you guys could have a look. I'd try to finish another PR in the upcoming days, that would get »exit with error« back, but as an optional config. |
|
This LGTM! |
Collaborator
|
Thanks for addressing this issue, @ta2edchimp. |
Collaborator
Author
Exactly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, do not exit with an error if ghooks is not found.
This is to a) fix #70 and b) the preparation to introduce that behavior as optional.