Migrate rolebindingtemplate controller to kubebuilder#683
Open
mirza-src wants to merge 5 commits intokubebuilder-migrationfrom
Open
Migrate rolebindingtemplate controller to kubebuilder#683mirza-src wants to merge 5 commits intokubebuilder-migrationfrom
mirza-src wants to merge 5 commits intokubebuilder-migrationfrom
Conversation
mirza-src
force-pushed
the
kubebuilder
branch
from
dd2cedb to
3a7be4c
Compare
Member
|
Since this will demand some work, in order to not leave rbac-operator un-releasable, we could point all the work to a new |
mirza-src
force-pushed
the
kubebuilder
branch
from
3a7be4c to
fd91fb2
Compare
mirza-src
changed the title
fhielpos
reviewed
Dec 8, 2025
mirza-src
force-pushed
the
kubebuilder
branch
from
fd91fb2 to
cbe1d60
Compare
stone-z
reviewed
Dec 18, 2025
Contributor
stone-z
left a comment
stone-z
left a comment
There was a problem hiding this comment.
This is already remarkably clean, given the scope. Well done 👏
I have some comments, also want to give this another pass and would welcome more team eyes. But overall, this is looking nice
Open
4 tasks
stone-z
reviewed
Jan 22, 2026
Contributor
stone-z
left a comment
stone-z
left a comment
There was a problem hiding this comment.
This is looking good to me now. Are there any trouble spots you anticipate that you want special attention on? Do you feel like the test coverage is adequate?
Comment on lines
+205
to
+208
| if updateErr := r.Status().Update(ctx, template); updateErr != nil { | ||
| log.Error(updateErr, errUpdateStatus) | ||
| } | ||
| return ctrl.Result{}, nil |
Contributor
There was a problem hiding this comment.
What are your thoughts on this re-queuing if the status update fails?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#3056
rolebindingtemplate
org-giantswarmnamespace, the subjects of the RB is filtered to only includeServiceAccounts that belong in eitherorg-giantswarmorflux-systemnamespace.Checklist