Skip to content

feature: add supprot for external | url method when create coveragestore#178

Merged
iamtekson merged 4 commits intogicait:masterfrom
maslke:feature-create-coveragestore
Aug 5, 2025
Merged

feature: add supprot for external | url method when create coveragestore#178
iamtekson merged 4 commits intogicait:masterfrom
maslke:feature-create-coveragestore

Conversation

@maslke
Copy link
Contributor

@maslke maslke commented May 22, 2025

Solved #22 : add support for external | url method in method create_coveragestore.

now we can use like this:

geoserver.create_coveragestore(
        path="http://localhost:8081/ECMWF_ERA-40_subset.nc",
        workspace="test",
        layer_name="url_netcdf",
        file_type="NetCDF",
        content_type="application/x-netcdf",
        method="external",
    )

Copy link
Collaborator

@iamtekson iamtekson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maslke, thank you very much for your contribution. It looks good with minor edits. I will accept the PR once it is updated.

@iboates
Copy link
Collaborator

iboates commented May 28, 2025

Please also consider writing tests to cover main functionality

@maslke
Copy link
Contributor Author

maslke commented May 28, 2025

I've optimized the code. Please take a look when it's convenient for you.

@maslke maslke mentioned this pull request May 29, 2025
Copy link
Collaborator

@iamtekson iamtekson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @maslke for your contribution.

@iamtekson iamtekson merged commit a4c853d into gicait:master Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants