1912/3 update bechmark tests#1915
Open
MarcelKoch wants to merge 1 commit into1912/2-use-new-json-inputfrom
Open
1912/3 update bechmark tests#1915MarcelKoch wants to merge 1 commit into1912/2-use-new-json-inputfrom
MarcelKoch wants to merge 1 commit into1912/2-use-new-json-inputfrom
Conversation
ginkgo-bot
added
reg:testing
6 tasks
MarcelKoch
force-pushed
the
1912/3-update-benchmark-tests
branch
from
7fb9a5a to
855e43e
Compare
MarcelKoch
force-pushed
the
1912/2-use-new-json-input
branch
from
c801b03 to
1011d52
Compare
MarcelKoch
force-pushed
the
1912/3-update-benchmark-tests
branch
from
855e43e to
4e70d06
Compare
MarcelKoch
force-pushed
the
1912/2-use-new-json-input
branch
from
1011d52 to
09dbcb7
Compare
MarcelKoch
force-pushed
the
1912/2-use-new-json-input
branch
from
09dbcb7 to
d00af3d
Compare
MarcelKoch
force-pushed
the
1912/3-update-benchmark-tests
branch
from
4e70d06 to
291303c
Compare
upsj
reviewed
Sep 29, 2025
Member
upsj
left a comment
upsj
left a comment
There was a problem hiding this comment.
Thanks for this massive effort 😄 Just a handful of clarification questions and comments on the resulting changes
| Running with 2 warm iterations and 1 running iterations | ||
| The random seed for right hand sides is 42 | ||
| Running cg with 1000 iterations and residual goal of 1.000000e-06 | ||
| Running with 1000 iterations and residual goal of 1.000000e-06 |
| Running test case stencil(100, 7pt) | ||
|
|
||
| Running test case | ||
| {"operator":{"stencil":{"name":"7pt","size":100}},"preconditioner":{"type":"preconditioner::Jacobi","max_block_size":32,"storage_optimization":[0,0],"skip_sorting":true},"format":"csr"} |
Member
There was a problem hiding this comment.
That's again one of these places where I think giving names to inputs and benchmarks would be useful
Member
Author
There was a problem hiding this comment.
Do you mean something like just printing the number of the json input?
Otherwise, I think we can't simplify the json representation, since we don't know what the important (i.e. changing between cases) part is.
| } | ||
| "repetitions": 1 | ||
| }, | ||
| "completed": true |
Member
There was a problem hiding this comment.
For my understanding: what happens, if individual benchmarks in here throw exceptions? Is completed then false for everything?
MarcelKoch
force-pushed
the
1912/3-update-benchmark-tests
branch
from
291303c to
ee9aa01
Compare
MarcelKoch
force-pushed
the
1912/2-use-new-json-input
branch
from
d00af3d to
2756446
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the benchmark tests with the new input.