Skip to content

Fix every calls to return values #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
manuelpuyol merged 2 commits into from
Jun 28, 2022
Merged

Fix every calls to return values #24

manuelpuyol merged 2 commits into from
Jun 28, 2022

Conversation

@manuelpuyol
Copy link
Contributor

@manuelpuyol manuelpuyol commented Jun 28, 2022

isSupported and isPolyfilled were always returning false, since .every requires the callback to return the value being checked

@manuelpuyol manuelpuyol requested a review from a team as a code owner June 28, 2022 18:00
@manuelpuyol manuelpuyol requested a review from theinterned June 28, 2022 18:00
@theinterned
Copy link
Contributor

theinterned commented Jun 28, 2022

nice find 😅

@manuelpuyol manuelpuyol merged commit acd5394 into main Jun 28, 2022
@keithamus keithamus deleted the fix-every-calls branch June 29, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theinterned theinterned theinterned approved these changes

@srt32 srt32 srt32 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@manuelpuyol @theinterned @srt32