feat: switch smoke-copilot-byok from cli-proxy to byok-copilot feature#2056
feat: switch smoke-copilot-byok from cli-proxy to byok-copilot feature#2056
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
Smoke Test Results
Overall: PASS
|
🔥 Smoke Test: Copilot BYOK (Offline) Mode
Running in BYOK offline mode ( Overall: PASS · PR by @lpcox · No assignees
|
There was a problem hiding this comment.
Pull request overview
Updates the Copilot BYOK smoke workflow to use the byok-copilot feature flag instead of cli-proxy.
Changes:
- Switch workflow frontmatter feature flag from
cli-proxy: truetobyok-copilot: true. - Regenerate the compiled lock workflow to reflect the updated frontmatter.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/smoke-copilot-byok.md | Updates the workflow’s features configuration to enable byok-copilot. |
| .github/workflows/smoke-copilot-byok.lock.yml | Recompiled lock file; includes runtime changes (Copilot CLI install version and model selection) that should be reconciled. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 2
| await main(); | ||
| - name: Install GitHub Copilot CLI | ||
| run: bash "${RUNNER_TEMP}/gh-aw/actions/install_copilot_cli.sh" 1.0.31 | ||
| run: bash "${RUNNER_TEMP}/gh-aw/actions/install_copilot_cli.sh" latest |
There was a problem hiding this comment.
The lock workflow now installs Copilot CLI using latest, which makes the workflow non-deterministic and diverges from the repository’s convention of pinning a specific CLI version (e.g., .github/workflows/smoke-copilot.lock.yml pins 1.0.21). Please pin to an explicit version (or a repo variable) so runs remain reproducible and less likely to break unexpectedly.
| run: bash "${RUNNER_TEMP}/gh-aw/actions/install_copilot_cli.sh" latest | |
| run: bash "${RUNNER_TEMP}/gh-aw/actions/install_copilot_cli.sh" 1.0.21 |
| COPILOT_API_KEY: dummy-byok-key-for-offline-mode | ||
| COPILOT_GITHUB_TOKEN: ${{ secrets.COPILOT_GITHUB_TOKEN }} | ||
| COPILOT_MODEL: ${{ vars.GH_AW_MODEL_AGENT_COPILOT || env.COPILOT_MODEL }} | ||
| COPILOT_MODEL: ${{ vars.GH_AW_MODEL_AGENT_COPILOT || 'claude-sonnet-4.6' }} |
There was a problem hiding this comment.
COPILOT_MODEL is now hard-coded to claude-sonnet-4.6, which ignores the workflow-level env.COPILOT_MODEL (currently claude-opus-4.6) and changes behavior beyond the PR’s stated intent. Consider reverting to the previous fallback (vars.GH_AW_MODEL_AGENT_COPILOT || env.COPILOT_MODEL) or updating the frontmatter/env so the configured model and runtime model are consistent.
🔥 Smoke Test Results
Overall: PASS — @lpcox (no assignees)
|
Smoke Test: GitHub Actions Services Connectivity ✅
All checks passed.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
Summary
Converts all Copilot
cli-proxyworkflows to the newbyok-copilotfeature flag.Workflows converted
smoke-copilot-byok.mdsmoke-copilot.mdsmoke-services.mdfirewall-issue-dispatcher.mdAll lock files recompiled and post-processed.