Skip to content

feat: switch smoke-copilot-byok from cli-proxy to byok-copilot feature#2056

Merged
lpcox merged 1 commit intomainfrom
copilot/smoke-byok-feature-flag
Apr 17, 2026
Merged

feat: switch smoke-copilot-byok from cli-proxy to byok-copilot feature#2056
lpcox merged 1 commit intomainfrom
copilot/smoke-byok-feature-flag

Conversation

@lpcox
Copy link
Copy Markdown
Collaborator

@lpcox lpcox commented Apr 17, 2026

Summary

Converts all Copilot cli-proxy workflows to the new byok-copilot feature flag.

Workflows converted

  • smoke-copilot-byok.md
  • smoke-copilot.md
  • smoke-services.md
  • firewall-issue-dispatcher.md

All lock files recompiled and post-processed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 17, 2026 14:44
@lpcox lpcox requested a review from Mossaka as a code owner April 17, 2026 14:44
@lpcox lpcox merged commit d8d84a6 into main Apr 17, 2026
41 of 44 checks passed
@lpcox lpcox deleted the copilot/smoke-byok-feature-flag branch April 17, 2026 14:45
@github-actions
Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 84.33% 84.41% 📈 +0.08%
Statements 83.56% 83.64% 📈 +0.08%
Functions 87.39% 87.39% ➡️ +0.00%
Branches 74.78% 74.82% 📈 +0.04%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/docker-manager.ts 86.8% → 87.1% (+0.30%) 86.4% → 86.7% (+0.29%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results

Overall: PASS

💥 [THE END] — Illustrated by Smoke Claude

@github-actions
Copy link
Copy Markdown
Contributor

🔥 Smoke Test: Copilot BYOK (Offline) Mode

Test Result
GitHub MCP (list merged PRs)
GitHub.com connectivity
File write/read
BYOK inference (agent → api-proxy → api.githubcopilot.com)

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com

Overall: PASS · PR by @lpcox · No assignees

🔑 BYOK report filed by Smoke Copilot BYOK

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Copilot BYOK smoke workflow to use the byok-copilot feature flag instead of cli-proxy.

Changes:

  • Switch workflow frontmatter feature flag from cli-proxy: true to byok-copilot: true.
  • Regenerate the compiled lock workflow to reflect the updated frontmatter.
Show a summary per file
File Description
.github/workflows/smoke-copilot-byok.md Updates the workflow’s features configuration to enable byok-copilot.
.github/workflows/smoke-copilot-byok.lock.yml Recompiled lock file; includes runtime changes (Copilot CLI install version and model selection) that should be reconciled.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 2

await main();
- name: Install GitHub Copilot CLI
run: bash "${RUNNER_TEMP}/gh-aw/actions/install_copilot_cli.sh" 1.0.31
run: bash "${RUNNER_TEMP}/gh-aw/actions/install_copilot_cli.sh" latest
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lock workflow now installs Copilot CLI using latest, which makes the workflow non-deterministic and diverges from the repository’s convention of pinning a specific CLI version (e.g., .github/workflows/smoke-copilot.lock.yml pins 1.0.21). Please pin to an explicit version (or a repo variable) so runs remain reproducible and less likely to break unexpectedly.

Suggested change
run: bash "${RUNNER_TEMP}/gh-aw/actions/install_copilot_cli.sh" latest
run: bash "${RUNNER_TEMP}/gh-aw/actions/install_copilot_cli.sh" 1.0.21

Copilot uses AI. Check for mistakes.
COPILOT_API_KEY: dummy-byok-key-for-offline-mode
COPILOT_GITHUB_TOKEN: ${{ secrets.COPILOT_GITHUB_TOKEN }}
COPILOT_MODEL: ${{ vars.GH_AW_MODEL_AGENT_COPILOT || env.COPILOT_MODEL }}
COPILOT_MODEL: ${{ vars.GH_AW_MODEL_AGENT_COPILOT || 'claude-sonnet-4.6' }}
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COPILOT_MODEL is now hard-coded to claude-sonnet-4.6, which ignores the workflow-level env.COPILOT_MODEL (currently claude-opus-4.6) and changes behavior beyond the PR’s stated intent. Consider reverting to the previous fallback (vars.GH_AW_MODEL_AGENT_COPILOT || env.COPILOT_MODEL) or updating the frontmatter/env so the configured model and runtime model are consistent.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Copy Markdown
Contributor

🔥 Smoke Test Results

Test Status
GitHub API (PR list) ✅ PR #2056: "feat: switch smoke-copilot-byok from cli-proxy to byok-copilot feature"
GitHub.com connectivity ✅ HTTP 200
File write/read /tmp/gh-aw/agent/smoke-test-copilot-24571087320.txt verified

Overall: PASS@lpcox (no assignees)

📰 BREAKING: Report filed by Smoke Copilot

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test: GitHub Actions Services Connectivity ✅

Check Result
Redis PING (host.docker.internal:6379) PONG
PostgreSQL ready (host.docker.internal:5432) accepting connections
PostgreSQL SELECT 1 (smoketest db, user postgres) ✅ Returns 1

All checks passed.

🔌 Service connectivity validated by Smoke Services

@github-actions
Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color 1/1 passed ✅ PASS
Go env 1/1 passed ✅ PASS
Go uuid 1/1 passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx All passed ✅ PASS
Node.js execa All passed ✅ PASS
Node.js p-limit All passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #2056 · ● 735.5K ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants