[duplicate-code] Duplicate Code Analysis Report

[github-actions]

Analysis of commit 7803dca

Summary

Analysis of the Go codebase found 2 significant duplication patterns across the internal/ packages. Both patterns exceed the reporting threshold (3+ similar instances or >10 lines of duplicated code).

Detected Patterns

1. Logger Setup Boilerplate - Severity: Medium - See sub-issue [duplicate-code] Duplicate Code Pattern: Logger Setup Boilerplate #4541
2. Server Config Lookup Duplication in Launcher - Severity: Low - See sub-issue [duplicate-code] Duplicate Code Pattern: Server Config Lookup in Launcher #4542

Overall Impact

• Total Duplicated Lines: ~50 lines across logger setup functions; ~10 lines in launcher
• Affected Files: internal/logger/file_logger.go, internal/logger/tools_logger.go, internal/logger/markdown_logger.go, internal/logger/jsonl_logger.go, internal/launcher/launcher.go
• Maintainability Risk: Medium — Logger setup boilerplate makes adding a new logger type error-prone
• Refactoring Priority: Low-Medium — The generic helpers in global_helpers.go already address part of the problem; the remaining boilerplate can be reduced

Next Steps

1. Review individual pattern sub-issues for detailed analysis
2. Prioritize refactoring based on severity and impact
3. Note: the internal/logger/global_helpers.go file already uses Go generics to abstract the mutex/init/close lifecycle — the remaining logger boilerplate is limited to the setup*Logger/handle*LoggerError function pairs

Analysis Metadata

• Analyzed Files: ~100 non-test Go files in internal/
• Excluded: *_test.go, test/ directory, workflow and agent config files
• Detection Method: Manual semantic analysis (grep-based pattern search; no Serena MCP available)
• Commit: 7803dca
• Analysis Date: 2026-04-25