ado2gh: Support GitHubProximaPipelines service connections for --rewire-pipelines

[Copilot]

Description

The ado2gh generate-script --rewire-pipelines command fails to recognize GitHub Enterprise Cloud with data residency service connections, which use type GitHubProximaPipelines instead of GitHub. This causes pipeline rewiring to fail despite valid service connections being configured.

Changes

• AdoApi.cs: Extended GetTeamProjectGithubAppId to accept both GitHub and GitHubProximaPipelines service connection types
• AdoApiTests.cs: Added test coverage for GitHubProximaPipelines service connections
• RELEASENOTES.md: Documented the change

Before:

var endpoint = response.FirstOrDefault(x => 
    ((string)x["type"]).Equals("GitHub", StringComparison.OrdinalIgnoreCase) && 
    ((string)x["name"]).Equals(githubOrg, StringComparison.OrdinalIgnoreCase));

After:

var endpoint = response.FirstOrDefault(x =>
    (((string)x["type"]).Equals("GitHub", StringComparison.OrdinalIgnoreCase) ||
     ((string)x["type"]).Equals("GitHubProximaPipelines", StringComparison.OrdinalIgnoreCase)) &&
    ((string)x["name"]).Equals(githubOrg, StringComparison.OrdinalIgnoreCase));

Checklist

• Did you write/update appropriate tests
• Release notes updated (if appropriate)
• Appropriate logging output
• Issue linked
• Docs updated (or issue created)
• New package licenses are added to ThirdPartyNotices.txt (if applicable)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>ado2gh: Support for ado2gh generate-script --rewire-pipelines for GitHub Enterprise cloud with data residency app</issue_title>
<issue_description>## Description

Running this command:

gh ado2gh generate-script --github-org <org> --ado-org ericsoderqvist --ado-team-project <project> --target-api-url https://api.<subdomain>.ghe.com --rewire-pipelines

Script for migrating repositories gets created, however the pipelines don't get rewired. The tool recognises the service connection but still give me this error in the logs:

[2025-11-11 10:48:01] [WARNING] CANNOT FIND GITHUB APP SERVICE CONNECTION IN ADO ORGANIZATION: ericsoderqvist. You must install the Pipelines app in GitHub and connect it to any Team Project in this ADO Org first.

From the code I can see that the value is hardcoded to look for service connections with type GitHub

The type for the GitHub Enterprise cloud with data residency app is GitHubProximaPipelines

Could this be added so migrations from Azure DevOps to GitHub with data residency becomes more friction free? </issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes ado2gh: Support for ado2gh generate-script --rewire-pipelines for GitHub Enterprise cloud with data residency app #1453

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull Request Overview

This PR adds support for GitHub Enterprise Cloud with data residency service connections in the ado2gh generate-script --rewire-pipelines command. The tool now recognizes both standard GitHub and GitHubProximaPipelines service connection types, resolving the issue where pipeline rewiring failed for GitHub Enterprise Cloud with data residency configurations.

Key changes:

• Extended service connection type matching to include GitHubProximaPipelines in addition to GitHub
• Added test coverage for the new service connection type
• Updated release notes to document the enhancement

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/Octoshift/Services/AdoApi.cs	Modified GetTeamProjectGithubAppId to accept both GitHub and GitHubProximaPipelines service connection types using OR logic
src/OctoshiftCLI.Tests/Octoshift/Services/AdoApiTests.cs	Added test case GetGithubAppId_Should_Recognize_GitHubProximaPipelines_Service_Connection to verify the new service connection type is recognized
RELEASENOTES.md	Added user-friendly description of the new feature in the Unreleased section

[github-actions]

Unit Test Results

  1 files    1 suites   10m 24s ⏱️
949 tests 949 ✅ 0 💤 0 ❌
950 runs  950 ✅ 0 💤 0 ❌

Results for commit 5eed024.

♻️ This comment has been updated with latest results.

[github-actions]

Package	Line Rate	Branch Rate	Complexity	Health
ado2gh	72%	70%	712	➖
Octoshift	83%	72%	1716	✔
bbs2gh	83%	77%	653	✔
gei	81%	72%	574	✔
Summary	80% (7695 / 9558)	73% (1812 / 2493)	3655	✔

[EricSoder]

Hi @brianaj, the gh ado2gh rewire-pipeline command is now working with GithubProximaPipelines service connection, but the ado2gh generate-script --rewire-pipelines command still won't output a rewire script in the migrate.ps1

Getting this error for ado2gh generate-script --rewire-pipelines:

2025-11-19 09:45:55] [INFO] Generating Script...
[2025-11-19 09:45:56] [WARNING] CANNOT FIND GITHUB APP SERVICE CONNECTION IN ADO ORGANIZATION: ericsoderqvist. You must install the Pipelines app in GitHub and connect it to any Team Project in this ADO Org first

Succesfull for gh ado2gh rewire-pipeline :

[2025-11-19 09:43:05] [INFO] Successfully rewired pipeline

[EricSoder]

@brianaj Found the problem! When setting up the service connection, the service connection name defaults to the name of the ADO organization. In the code it checks if the name is equal to the name of the githubOrg:

private async Task<string> GetTeamProjectGithubAppId(string org, string githubOrg, string teamProject)
{
    var url = $"{_adoBaseUrl}/{org.EscapeDataString()}/{teamProject.EscapeDataString()}/_apis/serviceendpoint/endpoints?api-version=6.0-preview.4";
    var response = await _client.GetWithPagingAsync(url);

    var endpoint = response.FirstOrDefault(x =>
        (((string)x["type"]).Equals("GitHub", StringComparison.OrdinalIgnoreCase) ||
         ((string)x["type"]).Equals("GitHubProximaPipelines", StringComparison.OrdinalIgnoreCase)) &&
        ((string)x["name"]).Equals(githubOrg, StringComparison.OrdinalIgnoreCase));

    return endpoint != null ? (string)endpoint["id"] : null;
}

I manually updated the service connection name to be equal to the name of my GitHub organization and then it worked :)

Maybe that check should be updated or the default naming from Azure DevOps should be changed?

However, now when I try to trigger the pipeline from GitHub it doesn't work. Maybe that is because I changed the service connection name? Or maybe I miss something?

[brianaj]

@EricSoder do you mind submitting the PR for review? I'm not fully understanding the issue here and can try to ping someone more familiar with the functionality to also review.

[EricSoder]

@brianaj, if this is not for you to take on, please let me know who I should @

This issue is this line:

((string)x["name"]).Equals(githubOrg, StringComparison.OrdinalIgnoreCase));

It checks wether the name of the service connection is the same as the name of the GitHub Organization where the Azure DevOps pipelines app is installed.

When you install the Azure DevOps pipelines app and go through the setup flow, it by default creates a service connection with the same name as the team project in ADO. There is no way I can change the naming in the setup flow.

Because of this, the ado2gh generate-script --rewire-pipelinescommand fails, because the name of the service connection is not equal to the name of my GitHub organization.

If I afterwards change the service connection name to be the same as my GitHub organization, it breaks the connection between ADO and GitHub.

Is this check necessary? If so, can the default naming from ADO be changed?

[brianaj]

@EricSoder unfortunately those more familiar with this code are no longer with the team. You can submit a PR so you can functionally test this and then we can go from there. The check was in place before my changes, hence why I didn't remove it.

[EricSoder]

@brianaj, PR submitted #1458