This repository was archived by the owner on Nov 1, 2017. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 46
Support task lists within block quotes #36
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2cf203e
failing test for updates
raganwald 6938647
Allow arbitrary nesting within block quotes
raganwald 681fec7
break the regex up for readability
raganwald d46789b
add a test for a nested block
raganwald 3212d66
integrate all update tests
raganwald 0084025
failing tests for numeric list items
raganwald 1003937
fix quoted ordered lists
raganwald 219e3fc
failing test for >>
raganwald 92bb768
handle >>
raganwald 3834435
clarify intent
raganwald File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -115,7 +115,11 @@ completePattern = /// | |
| # Useful when you need iterate over all items. | ||
| itemPattern = /// | ||
| ^ | ||
| (?:\s*[-+*]|(?:\d+\.))? # optional list prefix | ||
| (?: # optional prefix, consisting of | ||
| \s* # optional leading whitespace | ||
| (?:>\s*)* # zero or more blockquotes | ||
| (?:[-+*]|(?:\d+\.)) # list item indicator | ||
| )? | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 looks good. |
||
| \s* # optional whitespace prefix | ||
| ( # checkbox | ||
| #{escapePattern(complete)}| | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically this stanza should be
optional prefix; anditem indicatorwould need to be clarified aslist item indicator.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regexp looks solid! Thanks for the input, @aroben!