Skip to content
This repository was archived by the owner on Nov 1, 2017. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/assets/javascripts/task_list.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,11 @@ itemPattern = ///
#{escapePattern(complete)}|
#{escapePattern(incomplete)}
)
(?=\s) # followed by whitespace
(?! # is not a link
\s* # with optional whitespace
(?:\(.*?\)|\[.*?\]) # because of destination or reference
)
(?=\s) # is followed by whitespace
///

# Used to filter out code fences from the source for comparison only.
Expand Down
66 changes: 66 additions & 0 deletions test/unit/test_updates.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -440,3 +440,69 @@ asyncTest "update ignores items that look like Task List items but lack list pre
, 20

item2Checkbox.click()

asyncTest "update ignores items that look like Task List items but are links", ->
expect 3

$('#qunit-fixture').empty()

container = $ '<div>', class: 'js-task-list-container'

list = $ '<ul>', class: 'task-list'

item1 = $ '<li>', class: 'task-list-item'
item1Checkbox = $ '<input>',
type: 'checkbox'
class: 'task-list-item-checkbox'
disabled: true
checked: false

item2 = $ '<li>', class: 'task-list-item'
item2Checkbox = $ '<input>',
type: 'checkbox'
class: 'task-list-item-checkbox'
disabled: true
checked: false

field = $ '<textarea>', class: 'js-task-list-field', text: """
- [ ] (link)
- [ ] [reference]
- [ ] () collapsed
- [ ] [] collapsed reference
- [ ] \\(escaped item)
- [ ] item
"""

changes = """
- [ ] (link)
- [ ] [reference]
- [ ] () collapsed
- [ ] [] collapsed reference
- [ ] \\(escaped item)
- [x] item
"""

item1.append item1Checkbox
list.append item1
item1.expectedIndex = 1

item2.append item2Checkbox
list.append item2
item2.expectedIndex = 2

container.append list
container.append field

$('#qunit-fixture').append(container)
container.taskList()

field.on 'tasklist:changed', (event, index, checked) =>
ok checked
equal index, item2.expectedIndex
equal field.val(), changes

setTimeout ->
start()
, 20

item2Checkbox.click()