Skip to content

fix(ci): resolve invalid context access for new_version in release workflow #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benjaminloerincz wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −9
Open

fix(ci): resolve invalid context access for new_version in release workflow #532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,11 @@ on:
- "major"
- "minor"
- "patch"
update-language-server:
update-language-server:
required: true
description: "Update the language server to the latest version?"
type: boolean


jobs:
create-release-pr:
name: Create release PR
Expand All @@ -37,6 +36,7 @@ jobs:
node-version: "16"

- name: Bump version and push
id: bump_version
run: |
git config --global user.email "[email protected]"
git config --global user.name "GitHub Actions"
Expand All @@ -51,8 +51,8 @@ jobs:

git push --set-upstream origin release/$NEW_VERSION

echo "new_version=$NEW_VERSION" >> $GITHUB_ENV
echo "new_version=$NEW_VERSION" >> $GITHUB_OUTPUT

- name: Update language server
if: ${{ inputs.update-language-server }}
run: |
Expand All @@ -61,18 +61,18 @@ jobs:
npm i

- uses: stefanzweifel/git-auto-commit-action@3ea6ae190baf489ba007f7c92608f33ce20ef04a
with:
branch: release/${{ env.new_version }}
with:
branch: release/${{ steps.bump_version.outputs.new_version }}
if: ${{ inputs.update-language-server }}

- name: Create PR
run: |
LAST_PR=$(gh pr list --repo ${{ github.repository }} --limit 1 --state merged --search "Release version" --json number | jq -r '.[0].number')
./script/workflows/generate-release-notes.sh $LAST_PR ${{ env.new_version }}
./script/workflows/generate-release-notes.sh $LAST_PR ${{ steps.bump_version.outputs.new_version }}
gh pr create \
--title "Release version ${{ env.new_version }}" \
--title "Release version ${{ steps.bump_version.outputs.new_version }}" \
--body-file releasenotes.md \
--base main \
--head release/${{ env.new_version }}
--head release/${{ steps.bump_version.outputs.new_version }}
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}