Git submodules in multi-root workspace is not named correctly

[thetrompf]

• GitLens Version: 8.4.1
• VSCode Version: 1.24.1 (microsoft/vscode@24f6262)
• OS Version: Ubuntu 17.10

Steps to Reproduce:

1. Configure multi-root workspace with multiple git submodules
2. Use custom names for the workspace roots
3. The names for the git submodules do not have the same names as the VSCode SCM provider uses.

The names should have been, if they should match VSCode:
app -> wicotec
ansible -> ansible
static-content-server -> core

I think the problem is, that I have multiple workspace roots that points to different places in the same git submodule.

The directory layout on the filesystem looks like this:

wicotec                              (VS: root, git: wicotec)
    - app                            (VS: app, git: wicotec)
    - core                           (VS: core: git: core)
        - ansible                    (VS: ansible, git: core)
        - services
            - graphql-server         (VS: graphql-server, git: core)
            - authentication-server  (VS: authentication-server, git: core)
            ....
            - static-content-server  (VS: static-content-server, git: core

I don't know if it's better to follow VSCode names for the submodules, or something else should happen, or if they should follow the workspace root folder names, if not maybe you could detect which workspace root contains the submodule root (if exists), and name it after that?

[eamodio]

@thetrompf I've made some changes to the naming in a recent version of GitLens -- can you try out GitLens 9.3 and see if it improves things for you?

[thetrompf]

I'm still experiencing the same issue in the newest version:

filesystem	VS root	git repo
orbit git repo	root	orbit
orbit/app	app	orbit
orbit/core git submodule	core	orbit/core
orbit/core/ansible git submodule	ansible	orbit/ansible
orbit/core/graphql-server	graphql-server	orbit/core
orbit/core/services/authentication-server	authentication-server	orbit/core
orbit/core/static-content-server	static-content-server	orbit/core
...	...	...

The static-content-server in the screenshot above should have been core and app should have been orbit.