WebGPU: Carry pcg generator state through stage#728
Merged
gkjohnson merged 1 commit intogkjohnson:webgpu-pathtracerfrom Feb 27, 2026
Merged
WebGPU: Carry pcg generator state through stage#728gkjohnson merged 1 commit intogkjohnson:webgpu-pathtracerfrom
gkjohnson merged 1 commit intogkjohnson:webgpu-pathtracerfrom
Conversation
Owner
|
Thanks - passing the bounces value into the seed was a fairly lazy fix I forgot to got back and check 😅 In terms of randomness getting the "sobol" random function working is probably our better bet for stratified sampling functions. It provides a better result and should still be applicable for the wavefront path tracing approach. See this tweet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:

After:

From my understanding pseudo-random generators usually do not behave uniformly when sampling only a couple numbers before initializing with a new seed:
Issues got more pronounced with more complex bsdfs in #717, but here it is also visible.