-
Notifications
You must be signed in to change notification settings - Fork 5
Description
Currently, we only require a pyglotaran>=0.3.0
Line 33 in 59bc188
| pyglotaran>=0.3.0 |
To reduce code duplication and rely on functionality in pyglotaran (especially since we currently do not test against old pyglotaran versions) we could raise the required version for the 0.6.0 release for pyglotaran-extras to pyglotaran>=0.5.0.
With the planned implementation of TimeTraceProject (working name) we will have a hard requirement on pyglotaran>=0.6.0 for the release after that since it will inherit from the Project class
Thus I think it is reasonable to require the 0.(current - 1).0 version of pyglotaran.
Additional context
Since pyglotaran>=0.5.0 the result can be saved as yaml, which allows recreating results and thus "upgrading" results (given that the currently installed and original pyglotaran version aren't that far apart that deprecated specs were already removed).
In 0.6.0 saving as yml will be the default when calling result.save.
Upgrading the required pyglotaran version would also allow removing fallbacks for changed data variable names across versions e.g.
pyglotaran-extras/pyglotaran_extras/plotting/utils.py
Lines 243 to 246 in 59bc188
| if "species_concentration" in res: | |
| traces = res.species_concentration | |
| elif "species_associated_concentrations" in res: | |
| traces = res.species_associated_concentrations |
Additionally, glotaran/pyglotaran#869 implemented get_script_dir from the extras in pyglotaran itself so we currently have some code duplication.