Skip to content

🚧📚 Add reference to project PR to changelog#1044

Merged
jsnel merged 1 commit intoglotaran:mainfrom
s-weigand:add-project-to-changelog
Apr 2, 2022
Merged

🚧📚 Add reference to project PR to changelog#1044
jsnel merged 1 commit intoglotaran:mainfrom
s-weigand:add-project-to-changelog

Conversation

@s-weigand
Copy link
Member

@s-weigand s-weigand commented Apr 2, 2022

Just something we forgot in #869

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand changed the title 🚧📚 Add reference to project PR to changelog [skip ci] 🚧📚 Add reference to project PR to changelog Apr 2, 2022
@s-weigand s-weigand force-pushed the add-project-to-changelog branch from e214125 to 08f5103 Compare April 2, 2022 20:26
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/add-project-to-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.5.1 vs. main

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [96b42630]       [76ad059c]
     <v0.5.1>                   
         74.9±2ms         80.1±2ms     1.07  BenchmarkOptimize.time_optimize(False, False, False)
         162±20ms         166±10ms     1.02  BenchmarkOptimize.time_optimize(False, False, True)
         76.6±2ms         77.3±2ms     1.01  BenchmarkOptimize.time_optimize(False, True, False)
         161±20ms         144±40ms    ~0.89  BenchmarkOptimize.time_optimize(False, True, True)
         97.1±4ms         94.0±4ms     0.97  BenchmarkOptimize.time_optimize(True, False, False)
         103±10ms         100±40ms     0.97  BenchmarkOptimize.time_optimize(True, False, True)
         90.1±2ms         96.4±1ms     1.07  BenchmarkOptimize.time_optimize(True, True, False)
         101±20ms         117±30ms    ~1.16  BenchmarkOptimize.time_optimize(True, True, True)
             205M             202M     0.98  IntegrationTwoDatasets.peakmem_optimize
       2.36±0.07s       2.20±0.06s     0.93  IntegrationTwoDatasets.time_optimize

Benchmark diff main vs. PR

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [712170f3]       [76ad059c]
         80.1±2ms         80.1±2ms     1.00  BenchmarkOptimize.time_optimize(False, False, False)
         158±20ms         166±10ms     1.05  BenchmarkOptimize.time_optimize(False, False, True)
         76.6±1ms         77.3±2ms     1.01  BenchmarkOptimize.time_optimize(False, True, False)
         160±40ms         144±40ms    ~0.90  BenchmarkOptimize.time_optimize(False, True, True)
         90.9±1ms         94.0±4ms     1.03  BenchmarkOptimize.time_optimize(True, False, False)
        97.6±30ms         100±40ms     1.03  BenchmarkOptimize.time_optimize(True, False, True)
         97.3±5ms         96.4±1ms     0.99  BenchmarkOptimize.time_optimize(True, True, False)
         126±40ms         117±30ms     0.93  BenchmarkOptimize.time_optimize(True, True, True)
             209M             202M     0.97  IntegrationTwoDatasets.peakmem_optimize
       2.24±0.05s       2.20±0.06s     0.98  IntegrationTwoDatasets.time_optimize

@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.1%. Comparing base (712170f) to head (76ad059).
Report is 237 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1044   +/-   ##
=====================================
  Coverage   87.1%   87.1%           
=====================================
  Files        102     102           
  Lines       5381    5381           
  Branches     995     995           
=====================================
  Hits        4691    4691           
  Misses       536     536           
  Partials     154     154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsnel jsnel force-pushed the add-project-to-changelog branch from 08f5103 to 76ad059 Compare April 2, 2022 21:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jsnel jsnel merged commit 96e6861 into glotaran:main Apr 2, 2022
@jsnel jsnel deleted the add-project-to-changelog branch April 2, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants