Skip to content

📚 Update quickstart guide to use Project API#1241

Merged
s-weigand merged 4 commits intoglotaran:mainfrom
s-weigand:quickstart-project-api
Feb 19, 2023
Merged

📚 Update quickstart guide to use Project API#1241
s-weigand merged 4 commits intoglotaran:mainfrom
s-weigand:quickstart-project-api

Conversation

@s-weigand
Copy link
Member

@s-weigand s-weigand commented Feb 14, 2023

This PR updates the quickstart guide to using the project API with a single import.
Note that this is just a translation of the current quickstart guide to the Project API and not how the quickstart should look like for the 0.7.0 release.
For a proper quickstart we should incorporate the plotting functionality of the pyglotaran_extras so users can get an idea about the actual day to day workflow they would use.

Change summary

Documentation changes

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)
  • 🚧 Added changes to changelog (mandatory for all PR's)
  • 👌 Closes issue (mandatory for ✨ feature and 🩹 bug fix PR's)
  • 📚 Adds documentation of the feature

Closes issues

closes #1075

@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/quickstart-project-api

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 14, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.87%.

Quality metrics Before After Change
Complexity 0.83 ⭐ 0.89 ⭐ 0.06 👎
Method Length 16.67 ⭐ 27.33 ⭐ 10.66 👎
Working memory 3.33 ⭐ 2.89 ⭐ -0.44 👍
Quality 96.12% 94.25% -1.87% 👎
Other metrics Before After Change
Lines 27 31 4
Changed files Quality Before Quality After Quality Change
docs/remove_notebook_written_data.py 96.12% ⭐ 94.25% ⭐ -1.87% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2023

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.6.0 vs. main

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [6c3c390e]       [2bc0818e]
     <v0.6.0>                   
!      42.6±0.4ms           failed      n/a  BenchmarkOptimize.time_optimize(False, False, False)
!      46.4±0.8ms           failed      n/a  BenchmarkOptimize.time_optimize(False, False, True)
!      43.4±0.4ms           failed      n/a  BenchmarkOptimize.time_optimize(False, True, False)
!      47.2±0.6ms           failed      n/a  BenchmarkOptimize.time_optimize(False, True, True)
!      53.8±0.3ms           failed      n/a  BenchmarkOptimize.time_optimize(True, False, False)
!        149±50ms           failed      n/a  BenchmarkOptimize.time_optimize(True, False, True)
!      53.9±0.3ms           failed      n/a  BenchmarkOptimize.time_optimize(True, True, False)
!       57.3±30ms           failed      n/a  BenchmarkOptimize.time_optimize(True, True, True)
             206M             210M     1.02  IntegrationTwoDatasets.peakmem_optimize
-      1.65±0.05s       1.08±0.02s     0.65  IntegrationTwoDatasets.time_optimize

Benchmark diff main vs. PR

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [2bc0818e]       [b3e15018]
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, False, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, False, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, True, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, True, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, False, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, False, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, True, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, True, True)
             210M             210M     1.00  IntegrationTwoDatasets.peakmem_optimize
       1.08±0.02s       1.07±0.02s     0.99  IntegrationTwoDatasets.time_optimize

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 88.1% // Head: 88.1% // No change to project coverage 👍

Coverage data is based on head (b3e1501) compared to base (2bc0818).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1241   +/-   ##
=====================================
  Coverage   88.1%   88.1%           
=====================================
  Files        104     104           
  Lines       5064    5064           
  Branches     842     842           
=====================================
  Hits        4462    4462           
  Misses       484     484           
  Partials     118     118           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@s-weigand
Copy link
Member Author

s-weigand commented Feb 14, 2023

For now, this PR is a draft since it needs to be rebased after merging #1240, which it also doubles as a preview for.

@s-weigand s-weigand force-pushed the quickstart-project-api branch from 3883d7a to a625d52 Compare February 14, 2023 09:20
@s-weigand s-weigand mentioned this pull request Feb 14, 2023
3 tasks
@s-weigand s-weigand force-pushed the quickstart-project-api branch from fdf8d45 to 0222382 Compare February 15, 2023 08:17
@s-weigand
Copy link
Member Author

s-weigand commented Feb 16, 2023

Now waiting for #1244, so it properly renders 😅

@s-weigand s-weigand force-pushed the quickstart-project-api branch from 0222382 to e72cdd0 Compare February 18, 2023 18:45
@s-weigand s-weigand force-pushed the quickstart-project-api branch from e72cdd0 to b3e1501 Compare February 19, 2023 20:31
@s-weigand s-weigand marked this pull request as ready for review February 19, 2023 20:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve to merge, taking into account this important note:

"Note that this is just a translation of the current quickstart guide to the Project API and not how the quickstart should look like for the 0.7.0 release.
For a proper quickstart we should incorporate the plotting functionality of the pyglotaran_extras so users can get an idea about the actual day to day workflow they would use."
Agreed 💯

@s-weigand s-weigand merged commit f8d71c8 into glotaran:main Feb 19, 2023
@s-weigand s-weigand deleted the quickstart-project-api branch February 19, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📚 Update quickstart guide to use Project API

2 participants