{dontmerge]Scraping result

[joernweissenborn]

No description provided.

[github-actions]

👈 Launch a binder notebook on branch joernweissenborn/pyglotaran/scraping_result

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 1.44%.

Quality metrics	Before	After	Change
Complexity	6.93 ⭐	6.71 ⭐	-0.22 👍
Method Length	49.38 ⭐	47.18 ⭐	-2.20 👍
Working memory	7.51 🙂	7.26 🙂	-0.25 👍
Quality	69.95% 🙂	71.39% 🙂	1.44% 👍

Other metrics	Before	After	Change
Lines	4848	5156	308

Changed files	Quality Before	Quality After	Quality Change
glotaran/analysis/optimize.py	45.91% 😞	45.71% 😞	-0.20% 👎
glotaran/analysis/problem.py	80.36% ⭐	80.44% ⭐	0.08% 👍
glotaran/analysis/simulation.py	64.20% 🙂	64.20% 🙂	0.00%
glotaran/builtin/io/folder/folder_plugin.py	71.72% 🙂	61.82% 🙂	-9.90% 👎
glotaran/builtin/io/folder/test/test_folder_plugin.py	86.72% ⭐	93.57% ⭐	6.85% 👍
glotaran/builtin/io/netCDF/netCDF.py	79.78% ⭐	87.18% ⭐	7.40% 👍
glotaran/builtin/io/yml/yml.py	52.74% 🙂	78.42% ⭐	25.68% 👍
glotaran/builtin/io/yml/test/test_save_result.py	88.48% ⭐	95.76% ⭐	7.28% 👍
glotaran/io/init.py	87.99% ⭐	87.99% ⭐	0.00%
glotaran/io/interface.py	97.71% ⭐	97.52% ⭐	-0.19% 👎
glotaran/model/dataset_model.py	81.03% ⭐	80.93% ⭐	-0.10% 👎
glotaran/model/item.py	55.63% 🙂	56.94% 🙂	1.31% 👍
glotaran/model/model.py	72.67% 🙂	72.52% 🙂	-0.15% 👎
glotaran/model/property.py	43.98% 😞	48.19% 😞	4.21% 👍
glotaran/model/test/test_model.py	71.05% 🙂	70.88% 🙂	-0.17% 👎
glotaran/parameter/parameter_group.py	69.30% 🙂	69.30% 🙂	0.00%
glotaran/plugin_system/data_io_registration.py	92.67% ⭐	92.43% ⭐	-0.24% 👎
glotaran/plugin_system/project_io_registration.py	89.03% ⭐	87.08% ⭐	-1.95% 👎
glotaran/plugin_system/test/test_project_io_registration.py	91.22% ⭐	91.22% ⭐	0.00%
glotaran/project/init.py	%	%	%
glotaran/project/result.py	69.15% 🙂	76.39% ⭐	7.24% 👍
glotaran/project/scheme.py	90.75% ⭐	90.05% ⭐	-0.70% 👎
glotaran/project/test/test_result.py	80.10% ⭐	81.09% ⭐	0.99% 👍
glotaran/project/test/test_scheme.py	76.59% ⭐	76.97% ⭐	0.38% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
glotaran/model/item.py	_create_mprint_func	45 ⛔	275 ⛔	10 😞	25.00% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
glotaran/model/property.py	ModelProperty.validate	44 ⛔	187 😞	13 😞	25.34% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
glotaran/parameter/parameter_group.py	ParameterGroup.from_dataframe	28 😞	267 ⛔	13 😞	26.41% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
glotaran/analysis/optimize.py	_create_result	15 🙂	256 ⛔	23 ⛔	27.13% 😞	Try splitting into smaller methods. Extract out complex expressions
glotaran/model/item.py	_create_mprint_func.mprint_item	35 ⛔	270 ⛔	10 😞	28.28% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

No Coverage information
2.1% Duplication

[github-actions]

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [dc00e6da]       [9d61605b]
     <v0.4.0>                   
-        66.2±1ms         43.4±1ms     0.66  BenchmarkOptimize.time_optimize(False, False, False)
-         373±6ms        58.4±10ms     0.16  BenchmarkOptimize.time_optimize(False, False, True)
-        95.4±2ms         78.7±3ms     0.83  BenchmarkOptimize.time_optimize(False, True, False)
         95.8±2ms         86.6±5ms    ~0.90  BenchmarkOptimize.time_optimize(False, True, True)
         63.7±1ms         60.0±1ms     0.94  BenchmarkOptimize.time_optimize(True, False, False)
-         373±5ms         109±50ms     0.29  BenchmarkOptimize.time_optimize(True, False, True)
         92.8±1ms         94.0±1ms     1.01  BenchmarkOptimize.time_optimize(True, True, False)
         96.6±1ms         103±30ms     1.07  BenchmarkOptimize.time_optimize(True, True, True)
             180M             181M     1.01  IntegrationTwoDatasets.peakmem_create_result
             202M             199M     0.98  IntegrationTwoDatasets.peakmem_optimize
-        308±20ms          230±5ms     0.75  IntegrationTwoDatasets.time_create_result
        5.88±0.1s        2.01±0.1s    ~0.34  IntegrationTwoDatasets.time_optimize

[jsnel]

This was an experimental PR which has been superseded by a number of other smaller PRs:

• Add Dataset Groups #851
• ✨ Add simple decay megacomplexes #860
• Feature: Generators #866
• Refactor/save result (Sourcery refactored) #875
• ✨ Project Class #869