Update gradle builds#281
Merged
timotei merged 17 commits intogluck:masterfrom Feb 22, 2021
Merged
Conversation
Change-Id: I81c2745afc61f7fd29dc34e88ea0b463f33c3238
Change-Id: Ia63fa35d22ca1c97f4eb1277ccb08ada5d157a81
Change-Id: Ife00b5f45d180d92e57297b45a7c5b3e73f62e47
TLS 1.2 is now required to download package from nuget repository Change-Id: I7809ef17a25261c360e36336ef371221e7dda734
Change-Id: Id273591c91b8a24315663e4f337936e9ac05fe7e
Change-Id: I0313da92372eb623a3dea7b746f927c69cbe7a71
Closed
Change-Id: I62c9bf4c9628604aef77f44bdb5d4ca3c4d4e782
Change-Id: I91d2383eaeaaf55cd30645245dc2cf3700ed4036
florian-gandon
approved these changes
Feb 19, 2021
Contributor
florian-gandon
left a comment
florian-gandon
left a comment
There was a problem hiding this comment.
It looks good for me.
Contributor
Author
|
not sure why gradle cannot be downloaded yesterday https://ci.appveyor.com/project/gluck/il-repack/builds/37847904 |
not sure why it doesn't appear in build check now
Contributor
Author
|
looks really hard to resolve the msbuild issue on mono with the following error, dotnet/msbuild#2554 |
Contributor
Author
|
ok finally it is building in travis https://travis-ci.org/github/gluck/il-repack/builds/759767020 |
timotei
reviewed
Feb 22, 2021
| dotnet: 3.1.301 | ||
|
|
||
| env: | ||
| - MSBuildSDKsPath=/usr/share/dotnet/sdk/3.1.301/Sdks |
Collaborator
There was a problem hiding this comment.
Ah, this error. it was supposed to be fixed following dotnet/sdk#9632 and the related bugs though 🤔 But oh well
timotei
approved these changes
Feb 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support builds by latest msbuild