Don't strong name sign for delay signing#330
Merged
KirillOsenkov merged 1 commit intogluck:masterfrom Dec 22, 2023
Merged
Conversation
I found this as a major difference from ILMerge that causes some internal issues in our code. The change is to strong name sign the assembly only if it's not Delay Signed - that's ilmerge behavior. I'm pretty sure that should solve this issue gluck#290
KirillOsenkov
approved these changes
Dec 22, 2023
This was referenced Dec 22, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this as a major difference from ILMerge that causes some internal issues in our code. The change is to strong name sign the assembly only if it's not Delay Signed - that's ilmerge behavior. I'm pretty sure that should solve this issue #290