feature: added step for merging ILLink.*.xml files#339
Merged
KirillOsenkov merged 2 commits intogluck:masterfrom Jan 5, 2024
Merged
feature: added step for merging ILLink.*.xml files#339KirillOsenkov merged 2 commits intogluck:masterfrom
KirillOsenkov merged 2 commits intogluck:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a step that merges
ILLink.*.xmlfiles into the resulting assembly.I've tested its functionality on real assemblies. This is an optional feature enabled by the
/illinkflag (feel free to change the name).The implementation is optimal for 99% of cases; however, there are several shortcomings:
ILRepackcontext.System.Void Method2(System.Int32,System.String)and cannot be reliably fixed in the case of renames.ILLink.Suppressions.xml, so I referred to the source code from ILLink.