Skip to content

Migrate gnosis/solvers from ethereum-types to alloy#195

Merged
jmg-duarte merged 2 commits intoupdate-cow-dependencies/v2.340.0from
jmgd/alloy
Dec 22, 2025
Merged

Migrate gnosis/solvers from ethereum-types to alloy#195
jmg-duarte merged 2 commits intoupdate-cow-dependencies/v2.340.0from
jmgd/alloy

Conversation

@jmg-duarte
Copy link
Copy Markdown
Contributor

  • Fixes the compilation errors
  • Completely replaces the ethereum-types library with alloy
  • Makes the ChainId a u64 (the more accurate type); implementing a deserializer and tests
  • Replaces the old Address domain type with alloy's Address — like it was done in the backend
  • Re-uses eth::Address in more places

Copy link
Copy Markdown
Contributor

@squadgazzz squadgazzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MartinquaXD
Copy link
Copy Markdown
Contributor

Makes the ChainId a u64 (the more accurate type)

It's actually not as clear as one would think. 😅
The chain id is fundamentally a U256 but some time after chain ids were introduced some other EIP limited their range to something that fits inside u64 which led to this confusion.
So for internal logic u64 will work but for stuff like signing and RPC calls the chain id is expected as a U256.

Comment thread src/domain/dex/minimum_surplus.rs Outdated
@jmg-duarte jmg-duarte merged commit 23a02e4 into update-cow-dependencies/v2.340.0 Dec 22, 2025
3 checks passed
@jmg-duarte jmg-duarte deleted the jmgd/alloy branch December 22, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants