Make minio package support legacy MD5 checksum (#23768)#23770
Merged
lunny merged 2 commits intogo-gitea:release/v1.19from Mar 28, 2023
Merged
Make minio package support legacy MD5 checksum (#23768)#23770lunny merged 2 commits intogo-gitea:release/v1.19from
lunny merged 2 commits intogo-gitea:release/v1.19from
Conversation
A feedback from discord: https://discord.com/channels/322538954119184384/561007778139734027/1090185427115319386 Some storages like: * https://developers.cloudflare.com/r2/api/s3/api/ * https://www.backblaze.com/b2/docs/s3_compatible_api.html They do not support "x-amz-checksum-algorithm" header But minio recently uses that header with CRC32C by default. So we have to tell minio to use legacy MD5 checksum. I guess this needs to be backported because IIRC we 1.19 and 1.20 are using similar minio package. The minio package code for SendContentMD5 looks like this: <details> <img width="755" alt="image" src="https://user-images.githubusercontent.com/2114189/228186768-4f2f6f67-62b9-4aee-9251-5af714ad9674.png"> </details> # Conflicts: # custom/conf/app.example.ini # tests/pgsql.ini.tmpl
lunny
approved these changes
Mar 28, 2023
GiteaBot
added
the
lgtm/need 1
jolheiser
approved these changes
Mar 28, 2023
GiteaBot
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #23768 (no source code conflict, only some unrelated docs/test-ini conflicts)
Some storages like:
They do not support "x-amz-checksum-algorithm" header
But minio recently uses that header with CRC32C by default. So we have to tell minio to use legacy MD5 checksum.