workflow_dispatch use workflow from trigger branch

[ChristopherHX]

• htmx updates the input form on branch switch
• add workflow warning to dispatch modal
• use name if description of input is empty
• show error if workflow_dispatch not available on branch

Closes #33073
Closes #33099

[ChristopherHX]

I request feedback, e.g. a new name for workflow-dispatch-inputs.

Is there a blocker of using a branch specific workflows like discussed in? #33073

This change makes it more like how it is in GitHub Actions.

Warning

this is the first time I ever touched the code of both htmx and the gitea web ui
As 1.23 is in rc already, is it even possible for such a breaking change to be included

Further problem I noticed while testing this, if I leave description blank only the value selector is visible. Open a new bug report soon and eventually open a PR as well

See Demos (Updated 4 Jan 2025 (2))

• Showing an error if workflow doesn't exist on branch (problem only after submit, could not yet figure out how to add this to the template)
• Showing success to queue non default branch
• Showing inputs change per branch
• Showing workflow warning of respective branch in dispatch modal

Bildschirmaufnahme.2025-01-04.um.22.49.05.mov

---

Screenshot of correctly passed inputs to non default workflow:

My test instance just had an on: workflow_dispatch on the default branch without any inputs

[ChristopherHX]

For reference I used the following workflows both same file:

Default branch

on: workflow_dispatch
jobs:
  _:
    runs-on: ubuntu-latest
    steps:
    - run: ${{ tojson(inputs) }}
      shell: cat {0}

Non default branch

on:
  workflow_dispatch:
    inputs:
      test-a:
        type: boolean
      test-b:
        type: choice
        options:
        - a
        - b
        - c
        - d
      test-c:
        description: One with description!
        type: boolean
jobs:
  _:
    runs-on: windows-latest
    steps:
    - run: ${{ tojson(inputs) }}
      shell: cat {0}

[wxiaoguang]

I will make some changes

[ChristopherHX]

Feel free to do so :)

[wxiaoguang]

Made some changes (I haven't really tested since I am not sure whether it looks good):

1. introduce prepareWorkflowDispatchTemplate and prepareWorkflowList, then we do not need to use a lot of if blocks
2. add repo.MustBeNotEmpty middleware, then we do not need to check repo.IsEmpty
3. introduce CurWorkflowExists, not sure whether it is what you means
4. use or instead of Iif, or is simpler

By the way, if you'd like to make the text center-aligned, I think you could just add a tw-text-center class to the ui message

[ChristopherHX]

4. use or instead of Iif, or is simpler

I looked for coalesce and didn't notice we have a javascript like or 👍

3. introduce CurWorkflowExists, not sure whether it is what you means

This sounds like what I need.

By the way, if you'd like to make the text center-aligned, I think you could just add a tw-text-center class to the ui message

I technically just copied the html I found when triggering the workflow_dispatch.

So now I would change the error depending on CurWorkflowExists and add some new en-us locale definition

[wxiaoguang]

Thank you for confirming, I think I have finished my changes at the moment.

[wxiaoguang]

Is there anything need to improve? If no, let's merge.

(wait for a while for confirmation)

[ChristopherHX]

I checked again, everything on my TODO list is solved and confirmed this works as expected from my side