Fix remaining issues after gopls modernize formatting#34771
Merged
lunny merged 7 commits intogo-gitea:mainfrom Jun 18, 2025
Merged
Fix remaining issues after gopls modernize formatting#34771lunny merged 7 commits intogo-gitea:mainfrom
gopls modernize formatting#34771lunny merged 7 commits intogo-gitea:mainfrom
Conversation
GiteaBot
added
the
lgtm/need 2
silverwind
added
the
type/refactoring
silverwind
changed the title
gopls modernize formatting
delvh
approved these changes
Jun 18, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Jun 18, 2025
Contributor
wxiaoguang
left a comment
wxiaoguang
left a comment
There was a problem hiding this comment.
No idea what // from the fixtures means now ......
GiteaBot
added
lgtm/done
Member
Author
|
It refers to the removed variable: I guess we can make it more clear. |
silverwind
commented
Jun 18, 2025
silverwind
commented
Jun 18, 2025
silverwind
commented
Jun 18, 2025
silverwind
commented
Jun 18, 2025
lunny
reviewed
Jun 18, 2025
lunny
reviewed
Jun 18, 2025
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 19, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Upgrade `gopls` to v0.19.0, add `make fix` (go-gitea#34772) Refactor packages (func name & UI) (go-gitea#34773) Fix remaining issues after `gopls modernize` formatting (go-gitea#34771) Fix some package registry problems (go-gitea#34759) Fix incorrect cli default values and default command (go-gitea#34765) Support annotated tags when using create release API (go-gitea#31840) when using rules to delete packages, remove unclean bugs (go-gitea#34632) Fix readme path and markdown link paste (go-gitea#34755)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup #34751, fix all remaining marked issues.