Don't use full-file highlight when there is a git diff textconv#35114
Merged
wxiaoguang merged 2 commits intogo-gitea:mainfrom Jul 18, 2025
Merged
Don't use full-file highlight when there is a git diff textconv#35114wxiaoguang merged 2 commits intogo-gitea:mainfrom
wxiaoguang merged 2 commits intogo-gitea:mainfrom
Conversation
GiteaBot
added
the
lgtm/need 2
delvh
approved these changes
Jul 18, 2025
GiteaBot
added
lgtm/need 1
Member
|
How hard is it to add a test? |
Contributor
Author
Very hard, see the issue's steps ... so I think I don't have enough time to propose a test for it at the moment ....... Maybe in the future we can split the large function into small ones and test the small ones with some mock data (but this PR is small enough to backport) |
silverwind
approved these changes
Jul 18, 2025
GiteaBot
added
lgtm/done
Member
|
Yeah, should always extract testable functions, not have big untestable messes. |
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Jul 18, 2025
wxiaoguang
added
backport/done
wxiaoguang
added a commit
that referenced
this pull request
Jul 18, 2025
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 22, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Fix session gob (go-gitea#35128) Replace `setup-python` with `setup-uv` (go-gitea#35116) Don't use full-file highlight when there is a git diff textconv (go-gitea#35114) Fix submodule parsing when the gitmodules is missing (go-gitea#35109) Align `issue-title-buttons` with `list-header` (go-gitea#35018)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #35106