Remove unneeded if statements for update repo API

[6543]

just try to make the update func more redable and be more KISS

---

Sponsored by Kithara Software GmbH

[6543]

TestAPIRepoEdit fails but i dont know why jet

[lunny]

It's related. The logic is different from previous implementation. All UnitEnabled missed.

[6543]

of course it was related ... see fix

and the check if unit exists is not needed and was already missing in some unit update codeblocks ...

[6543]

• in case a unit does not exist and is going to be marked as deleted -> db query will just ignore it as there is no match
• in case a unit does exist and is going to be marked as deleted -> db query will match and delete it
• in case a unit dose exist and the option defines a new one, before the new values are set the unit gets deteted and recreated with the new settings -> no check needed if it exist because it will be deleted before if so
• in case a unit dose not exist and the option defines a new one, it gets created with the new settings -> no check needed

[6543]

was an logic issue ... where two excluse unit tyes exist and there globalEnabled check was if-else-if chained ...

[lunny]

was an logic issue ... where two excluse unit tyes exist and there globalEnabled check was if-else-if chained ...

The logic changed.
Before

(opts.HasIssues == nil && currHasIssues == true) || (opts.HasIssues != nil && *opts.HasIssues)

After

(opts.HasIssues != nil && *opts.HasIssues)

[6543]

@lunny thats not true ... its:

(opts.HasIssues != nil && *opts.HasIssues && externalEnabled) or
(opts.HasIssues != nil && *opts.HasIssues && internalEnabled) or
(opts.HasIssues != nil && !*opts.HasIssues)