Allow foreachref parser to grow its buffer (#35365)#35376
Merged
wxiaoguang merged 1 commit intogo-gitea:release/v1.24from Aug 29, 2025
Merged
Allow foreachref parser to grow its buffer (#35365)#35376wxiaoguang merged 1 commit intogo-gitea:release/v1.24from
wxiaoguang merged 1 commit intogo-gitea:release/v1.24from
Conversation
Fixes go-gitea#35221, let the scanner's buffer grow up to 4x (256 kiB), and add an error check --------- Signed-off-by: Fabian Meyer <fabian.meyer@lawo.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Aug 29, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Aug 29, 2025
GiteaBot
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #35365 by @meyfa-lawo
Fixes #35221. Firstly, lets the scanner's buffer grow up to 4x (256 kiB) instead of being limited to 64 kiB, which is too small for the commit message mentioned in the issue report. Secondly, adds an error check as recommended by the documentation: https://pkg.go.dev/bufio#Scanner.Scan