use experimental go json v2 library by junoberryferry · Pull Request #35392 · go-gitea/gitea

junoberryferry · 2025-08-31T21:35:59Z

details: https://pkg.go.dev/encoding/json/v2

go.mod

Signed-off-by: techknowlogick <matti@mdranta.net>

modules/json/jsonv2.go

Signed-off-by: techknowlogick <matti@mdranta.net>

modules/json/jsonv2.go

Signed-off-by: techknowlogick <matti@mdranta.net>

modules/json/jsonv2.go

Signed-off-by: techknowlogick <matti@mdranta.net>

modules/json/jsonv2.go

Signed-off-by: techknowlogick <matti@mdranta.net>

modules/json/jsonv2_fallback.go

Signed-off-by: techknowlogick <matti@mdranta.net>

techknowlogick · 2025-09-02T23:59:03Z

@junoberryferry I'm sorry for all the notifications. I've just resolved the linting errors on my phone. Thanks for this PR!

modules/json/jsonv2_fallback.go

Signed-off-by: techknowlogick <matti@mdranta.net>

lunny · 2025-09-03T00:01:32Z

Since it's not enabled by default. GOEXPERIMENT=jsonv2 is needed. I don't think this should be merged into v1.25

modules/json/jsonv2_fallback.go

Signed-off-by: techknowlogick <matti@mdranta.net>

wxiaoguang · 2025-09-28T04:18:42Z

Anything else to change?

silverwind · 2025-09-29T06:40:19Z

Makefile


+# By default use go's 1.25 experimental json v2 library when building
+# TODO: remove when no longer experimental
+export GOEXPERIMENT ?= jsonv2


fyi we do not use submake, so this export is useless.

Why it is "useless"? Will go ... inherit non-exported variables?

Yes, all commands will see the variables like FOO ?= bar, export in a Makefile is only for sub-make:

https://www.gnu.org/software/make/manual/html_node/Variables_002fRecursion.html#Communicating-Variables-to-a-Sub_002dmake

Are you sure or have you tested? I don't think the the GNU toolchain can have such a counterintuitive, global-polluting and dirty design.

Details

Maybe you are right. My test was incorrect. I have always used the explicit form VAR=$(VAR) cmd so far, which explicitly passes variables. I think it's the most clean way, especially because the Makefile handles a lot of other commands that don't accept GOEXPERIMENT.

I agree that "export" is not the best approach, while it just works, so I just kept the original change from techknowlogick's 94d537c

details: https://pkg.go.dev/encoding/json/v2 --------- Co-authored-by: techknowlogick <matti@mdranta.net> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

* giteaofficial/main: fix: auto-expand and auto-scroll for actions logs (go-gitea#35570) (go-gitea#35583) [skip ci] Updated translations via Crowdin [skip ci] Updated translations via Crowdin Fix creating pull request failure when the target branch name is the same as some tag (go-gitea#35552) Use bundled version of spectral (go-gitea#35573) Add rebase push display wrong comments bug (go-gitea#35560) Address some CodeQL security concerns (go-gitea#35572) fix(webhook): prevent tag events from bypassing branch filters targets go-gitea#35449 (go-gitea#35567) Added button to copy file name in PR files (go-gitea#35509) Update JS and PY deps (go-gitea#35565) Enable a few more tsconfig options (go-gitea#35553) Bump github.com/wneessen/go-mail from 0.6.2 to 0.7.1 (go-gitea#35557) add more routes to the "expensive" list (go-gitea#35547) Drop json-iterator dependency (go-gitea#35544) Add proper error message if session provider can not be created (go-gitea#35520) use experimental go json v2 library (go-gitea#35392) Use global lock instead of status pool for cron lock (go-gitea#35507) Move some functions to gitrepo package (go-gitea#35503) Move GetDiverging functions to gitrepo (go-gitea#35524) [skip ci] Updated translations via Crowdin

use experimental go json v2 library

c5f251b

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 31, 2025

github-actions bot added modifies/go Pull requests that update Go code modifies/internal modifies/dependencies labels Aug 31, 2025

techknowlogick reviewed Aug 31, 2025

View reviewed changes

go.mod Outdated Show resolved Hide resolved

techknowlogick and others added 2 commits September 1, 2025 19:35

Merge branch 'main' into jsonv2

cb16b33

Update go.mod

abc734c

Signed-off-by: techknowlogick <matti@mdranta.net>

github-actions bot removed the modifies/dependencies label Sep 2, 2025

techknowlogick reviewed Sep 2, 2025

View reviewed changes

modules/json/jsonv2.go Outdated Show resolved Hide resolved

Update jsonv2.go

f9c8805

Signed-off-by: techknowlogick <matti@mdranta.net>

techknowlogick reviewed Sep 2, 2025

View reviewed changes

modules/json/jsonv2.go Outdated Show resolved Hide resolved

Update jsonv2.go

9d83440

Signed-off-by: techknowlogick <matti@mdranta.net>

techknowlogick reviewed Sep 2, 2025

View reviewed changes

modules/json/jsonv2.go Show resolved Hide resolved

Update jsonv2.go

31492c1

Signed-off-by: techknowlogick <matti@mdranta.net>

techknowlogick approved these changes Sep 2, 2025

View reviewed changes

modules/json/jsonv2.go Show resolved Hide resolved

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 2, 2025

Update jsonv2.go

7b0832c

Signed-off-by: techknowlogick <matti@mdranta.net>

techknowlogick approved these changes Sep 2, 2025

View reviewed changes

modules/json/jsonv2_fallback.go Outdated Show resolved Hide resolved

modules/json/jsonv2_fallback.go Outdated Show resolved Hide resolved

modules/json/jsonv2_fallback.go Outdated Show resolved Hide resolved

techknowlogick and others added 4 commits September 2, 2025 19:57

Update jsonv2_fallback.go

fe51938

Signed-off-by: techknowlogick <matti@mdranta.net>

Update jsonv2_fallback.go

29d1770

Signed-off-by: techknowlogick <matti@mdranta.net>

Update jsonv2_fallback.go

3c3f77f

Signed-off-by: techknowlogick <matti@mdranta.net>

Merge branch 'main' into jsonv2

ce4107d

techknowlogick approved these changes Sep 3, 2025

View reviewed changes

modules/json/jsonv2_fallback.go Outdated Show resolved Hide resolved

Update jsonv2_fallback.go

b8fb94d

Signed-off-by: techknowlogick <matti@mdranta.net>

techknowlogick approved these changes Sep 3, 2025

View reviewed changes

modules/json/jsonv2_fallback.go Outdated Show resolved Hide resolved

Update jsonv2_fallback.go

c748ca8

Signed-off-by: techknowlogick <matti@mdranta.net>

wxiaoguang force-pushed the jsonv2 branch from bcf9659 to 706cb44 Compare September 26, 2025 18:49

fix

cb47618

wxiaoguang force-pushed the jsonv2 branch 3 times, most recently from e63d111 to 47cc820 Compare September 26, 2025 19:36

fix

f302ca8

wxiaoguang force-pushed the jsonv2 branch from 47cc820 to f302ca8 Compare September 26, 2025 19:39

wxiaoguang marked this pull request as ready for review September 26, 2025 20:04

wxiaoguang approved these changes Sep 26, 2025

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 26, 2025

wxiaoguang added this to the 1.26.0 milestone Sep 26, 2025

wxiaoguang force-pushed the jsonv2 branch 3 times, most recently from 46fa69e to d810180 Compare September 27, 2025 05:01

fine tune

ad93826

wxiaoguang force-pushed the jsonv2 branch from d810180 to ad93826 Compare September 27, 2025 05:40

wxiaoguang removed their assignment Sep 27, 2025

lunny approved these changes Sep 28, 2025

View reviewed changes

Merge branch 'main' into jsonv2

7f23bb9

wxiaoguang enabled auto-merge (squash) September 28, 2025 07:37

wxiaoguang merged commit 151ef80 into go-gitea:main Sep 28, 2025
26 checks passed

silverwind reviewed Sep 29, 2025

View reviewed changes

go-gitea locked as resolved and limited conversation to collaborators Dec 27, 2025

Uh oh!

Comments

Conversation

junoberryferry commented Aug 31, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

techknowlogick commented Sep 2, 2025

Uh oh!

Uh oh!

lunny commented Sep 3, 2025

Uh oh!

Uh oh!

wxiaoguang commented Sep 28, 2025

Uh oh!

Uh oh!

silverwind Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

silverwind Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

silverwind Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

silverwind Sep 29, 2025 •

edited

Loading

wxiaoguang Sep 29, 2025 •

edited

Loading