Skip to content

Comments

Refactor legacy code, fix LFS auth bypass, fix symlink bypass (#35708)#35716

Merged
wxiaoguang merged 1 commit intogo-gitea:release/v1.25from
GiteaBot:backport-35708-v1.25
Oct 21, 2025
Merged

Refactor legacy code, fix LFS auth bypass, fix symlink bypass (#35708)#35716
wxiaoguang merged 1 commit intogo-gitea:release/v1.25from
GiteaBot:backport-35708-v1.25

Conversation

@GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Oct 21, 2025

Backport #35708 by wxiaoguang

And by the way, remove the legacy TODO, split large functions into small
ones, and add more tests
@GiteaBot GiteaBot added modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code labels Oct 21, 2025
@GiteaBot GiteaBot added this to the 1.25.0 milestone Oct 21, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 21, 2025
@GiteaBot GiteaBot requested review from delvh and lunny October 21, 2025 05:19
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 21, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) October 21, 2025 05:20
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 21, 2025
@wxiaoguang wxiaoguang merged commit ac6d38e into go-gitea:release/v1.25 Oct 21, 2025
26 checks passed
@wxiaoguang wxiaoguang changed the title Refactor legacy code (#35708) Refactor legacy code, fix LFS auth bypass, fix symlink bypass (#35708) Oct 26, 2025
@wxiaoguang wxiaoguang added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Oct 26, 2025
@xnox xnox mentioned this pull request Dec 7, 2025
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code topic/security Something leaks user information or is otherwise vulnerable. Should be fixed!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants