Conversation
|
I actually missed a placeholder job log of all queued (waiting) jobs that contains the actual runner label. The advantage over could be run-list performance, on the other hand it is also nice to not need to go into the job list at all. |
Maybe we can add this warning to the job list later as well. |
8406d10 to
fb296a3
Compare
wxiaoguang
left a comment
There was a problem hiding this comment.
Please check whether new changes look good
The left one: it is not a sentence, left is name, right is icon, two "block" elements. The right one: it is in a sentence "commit xxx pushed by yyy". So the texts need 0.25em gap. If you'd like to add gap for the icon, the layout needs to be |
Thank you! Now I understand this. Looks good to me. |
* giteaofficial/main: [skip ci] Updated translations via Crowdin Revert go-gitea#18491, fix oauth2 client link account (go-gitea#35745) Upgrade go mail to 0.7.2 (go-gitea#35748) [skip ci] Updated translations via Crowdin Support actions and reusable workflows from private repos (go-gitea#32562) Use git model to detect whether branch exist instead of gitrepo method (go-gitea#35459) Fix shutdown waitgroup panic (go-gitea#35676) Intorduce "config edit-ini" sub command to help maintaining INI config file (go-gitea#35735) Improve online runner check (go-gitea#35722) Make "update file" API can create a new file when SHA is not set (go-gitea#35738) Fix review request webhook bug (go-gitea#35339) (go-gitea#35723) Misc tool tweaks (go-gitea#35734) Update dependencies (go-gitea#35733) Make external iframe render work (go-gitea#35730) Remove mermaid margin workaround (go-gitea#35732) # Conflicts: # models/user/user.go

This PR moves "no online runner" warning to the runs list.
A job's
runs-onmay contain expressions likeruns-on: [self-hosted, "${{ inputs.chosen-os }}"]so the value ofruns-onmay be different in each run. We cannot check it through the workflow file.Screenshots
Before:
After:
This PR also splits
prepareWorkflowDispatchTemplatefunction into 2 functions:prepareWorkflowTemplateget and check all of the workflowsprepareWorkflowDispatchTemplateonly prepare workflow dispatch config forworkflow_dispatchworkflows.