Skip to content

Comments

Fix #35763: Add proper page title for project pages#35773

Merged
lunny merged 4 commits intogo-gitea:mainfrom
mithileshgupta12:fix/35763-project-page-title
Nov 9, 2025
Merged

Fix #35763: Add proper page title for project pages#35773
lunny merged 4 commits intogo-gitea:mainfrom
mithileshgupta12:fix/35763-project-page-title

Conversation

@mithileshgupta12
Copy link
Contributor

@mithileshgupta12 mithileshgupta12 commented Oct 29, 2025 •
edited
Loading

No description provided.

@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Oct 29, 2025
@mithileshgupta12 mithileshgupta12 mentioned this pull request Oct 29, 2025
Closed
@silverwind
Copy link
Member

silverwind commented Oct 29, 2025 •
edited
Loading

@wxiaoguang should this use PageTitleCommon added in https://github.com/go-gitea/gitea/pull/35772/files? I wonder why its not named PageTitle.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Oct 29, 2025

I wonder why its not named PageTitle.

PageTitle conflicts with Title when reading

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Oct 29, 2025

should this use PageTitleCommon added in https://github.com/go-gitea/gitea/pull/35772/files?

I think the current code is good enough. PageTitleCommon is a suffix when Title exists.

wxiaoguang
wxiaoguang reviewed Oct 29, 2025
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 29, 2025
@mithileshgupta12 mithileshgupta12 force-pushed the fix/35763-project-page-title branch from fbf3e17 to 43a30b6 Compare October 30, 2025 03:20
@silverwind
Copy link
Member

silverwind commented Nov 4, 2025

Tested it, works in all cases:

  • user/repo project
  • org/repo project
  • org project

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 4, 2025
@silverwind
Copy link
Member

silverwind commented Nov 4, 2025

Could backport as a trivial enhancement.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 4, 2025
lunny
lunny requested changes Nov 4, 2025
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will panic for an anonymous view?

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Nov 4, 2025
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Nov 5, 2025

It will panic for an anonymous view?

I guess no. ContextUser is for the owner in the path, not "doer"

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Nov 5, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 9, 2025
@lunny lunny enabled auto-merge (squash) November 9, 2025 20:55
@lunny lunny merged commit 60314cb into go-gitea:main Nov 9, 2025
25 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Nov 9, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 9, 2025
@mithileshgupta12 @GiteaBot
Add proper page title for project pages (go-gitea#35773)
e615da3 
Fix go-gitea#35763

Co-authored-by: Mithilesh Gupta <guptamithilesh@protonmail.com>
@GiteaBot GiteaBot mentioned this pull request Nov 9, 2025
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Nov 9, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 10, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
079ad07 
* giteaofficial/main:
  Allow to display embed images/pdfs when SERVE_DIRECT was enabled on MinIO storage (go-gitea#35882)
  Add proper page title for project pages (go-gitea#35773)
  Use correct form field for allowed force push users in branch protection API (go-gitea#35894)
  Fix team member access check (go-gitea#35899)
  Add ability for local makefile with personal customizations that wouldnt affect remote repo (go-gitea#35836)
  Add toolchain directive to go.mod (go-gitea#35901)
  Display source code downloads last for release attachments (go-gitea#35897)
  Fix conda null depend issue (go-gitea#35900)
  Fix avatar upload error handling (go-gitea#35887)
  Move `gitea-vet` to use `go tool` (go-gitea#35878)
  Contribution heatmap improvements (go-gitea#35876)
  Update to go 1.25.4 (go-gitea#35877)
lafriks pushed a commit that referenced this pull request Nov 10, 2025
@GiteaBot @mithileshgupta12
Fix #35763: Add proper page title for project pages (#35773) (#35909)
db876d8 
Backport #35773 by @mithileshgupta12

Co-authored-by: Mithilesh Gupta <mithileshgupta059@gmail.com>
Co-authored-by: Mithilesh Gupta <guptamithilesh@protonmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 24, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/release/v1.25'
0a09b13 
* giteaofficial/release/v1.25: (77 commits)
  Add "site admin" back to profile menu (go-gitea#36010) (go-gitea#36013)
  release notes for 1.25.2 (go-gitea#35986)
  Allow empty commit when merging pull request with squash style (go-gitea#35989) (go-gitea#36003)
  Fix various permission & login related bugs (go-gitea#36002) (go-gitea#36004)
  upgrade golang.org/x/crypto to 0.45.0 (go-gitea#35988)
  Change project default column icon to 'star' (go-gitea#35967) (go-gitea#35979)
  Misc CSS fixes (go-gitea#35888) (go-gitea#35981)
  Fix container push tag overwriting (go-gitea#35936) (go-gitea#35954)
  Fix corrupted external render content (go-gitea#35946) (go-gitea#35950)
  Don't show unnecessary error message to end users for DeleteBranchAfterMerge (go-gitea#35937) (go-gitea#35941)
  Limit read bytes instead of ReadAll (go-gitea#35928) (go-gitea#35934)
  Load jQuery as early as possible to support custom scripts (go-gitea#35926) (go-gitea#35929)
  Allow to display embed images/pdfs when SERVE_DIRECT was enabled on MinIO storage (go-gitea#35882) (go-gitea#35917)
  Use correct form field for allowed force push users in branch protection API (go-gitea#35894) (go-gitea#35908)
  Make OAuth2 issuer configurable (go-gitea#35915) (go-gitea#35916)
  Fix go-gitea#35763: Add proper page title for project pages (go-gitea#35773) (go-gitea#35909)
  Display source code downloads last for release attachments (go-gitea#35897) (go-gitea#35903)
  Fix team member access check (go-gitea#35899) (go-gitea#35905)
  Fix conda null depend issue (go-gitea#35900) (go-gitea#35902)
  Fix avatar upload error handling (go-gitea#35887) (go-gitea#35890)
  ...

# Conflicts:
#	go.mod
#	go.sum
#	models/actions/run_test.go
#	models/fixtures/action_run.yml
#	models/fixtures/action_run_job.yml
#	models/fixtures/action_task.yml
#	models/fixtures/branch.yml
#	models/fixtures/repo_unit.yml
#	modules/git/tree_entry_gogit.go
#	modules/git/tree_gogit.go
#	routers/web/repo/actions/view.go
#	routers/web/repo/issue_comment.go
#	services/actions/workflow.go
#	services/doctor/actions_test.go
#	services/pull/comment.go
#	services/pull/pull.go
#	services/pull/temp_repo.go
#	templates/base/head_navbar.tmpl
#	templates/swagger/v1_json.tmpl
#	tests/integration/actions_schedule_test.go
#	tests/integration/git_lfs_ssh_test.go
#	tests/integration/pull_create_test.go
#	tests/integration/pull_merge_test.go
#	tests/sqlite.ini.tmpl
#	web_src/js/components/ContextPopup.vue
@xnox xnox mentioned this pull request Dec 7, 2025
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

6 participants

@mithileshgupta12 @silverwind @wxiaoguang @lunny @delvh @GiteaBot