Skip to content

Comments

Update JS deps#35978

Merged
silverwind merged 4 commits intogo-gitea:mainfrom
silverwind:deps-102
Nov 20, 2025
Merged

Update JS deps#35978
silverwind merged 4 commits intogo-gitea:mainfrom
silverwind:deps-102

Conversation

@silverwind
Copy link
Member

Update JS deps, regenerate SVGs, fixed lint issues and did cursory testing of UI.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 18, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 19, 2025
@silverwind
Copy link
Member Author

Updated again, fix new markdownlint issue and also added a make lint-md-fix (it did not autofix unfortunately).

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 20, 2025
@lunny
Copy link
Member

lunny commented Nov 20, 2025

Why were these new octicon-xxx icons added? It seems they aren’t used anywhere in the codebase. Could you clarify their purpose?

@delvh
Copy link
Member

delvh commented Nov 20, 2025

@lunny they came from the updated octicon dependency.

@silverwind
Copy link
Member Author

silverwind commented Nov 20, 2025

We generate all svgs into the repo, only the used ones will actually end up in the build.

@silverwind silverwind enabled auto-merge (squash) November 20, 2025 08:07
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 20, 2025
@silverwind silverwind merged commit 1baca49 into go-gitea:main Nov 20, 2025
25 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Nov 20, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 20, 2025
@silverwind silverwind deleted the deps-102 branch November 20, 2025 22:21
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 22, 2025
* giteaofficial/main:
  Fix various permission & login related bugs (go-gitea#36002)
  Allow empty commit when merging pull request with squash style (go-gitea#35989)
  [skip ci] Updated translations via Crowdin
  Mention proc-receive in text for dashboard.resync_all_hooks func (go-gitea#35991)
  Update JS deps (go-gitea#35978)
  wiki: reuse selectable style for wiki (go-gitea#35990)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/docs modifies/frontend modifies/internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants