Rework Create release functions

[lunny]

• Add a tag name invalidate name error check when creating tag from the UI
• Rework CreateRelease, CreateNewTag and UpdateRelease
• Fix the bug it will never work when creating a release from a UI-created-tag.

[wxiaoguang]

"// Trim '--' prefix to prevent command line argument vulnerability."

How it can be right? Where is the vulnerability? If you think there is a vulnerability, why don't you fix the branch names?

[lunny]

"// Trim '--' prefix to prevent command line argument vulnerability."

How it can be right? Where is the vulnerability? If you think there is a vulnerability, why don't you fix the branch names?

Removed at 9e37d1b which introduced at 0a78d99#diff-ff6356f0c6f4aae97d82e1c488527eb91065a8a7e474add4e74cdc5bd167f7caR70-R71

[lunny]

This is ready to review now.

[Copilot]

Pull request overview

Reworks release/tag creation flows to support UI-created tags, adds invalid tag name checks, and threads request context through release service calls.

Changes:

• Introduced createGitTag and refactored CreateRelease, CreateNewTag, and UpdateRelease to use context.Context and handle existing tags.
• Updated web/API/test call sites to pass context into CreateRelease.
• Improved branch creation error handling by adding invalid tag name feedback.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
tests/integration/mirror_pull_test.go	Updates integration test to pass context into CreateRelease.
services/release/release_test.go	Updates tests for new CreateRelease signature and adds basic createGitTag coverage.
services/release/release.go	Major refactor: new createGitTag, context-aware CreateRelease, updated CreateNewTag + UpdateRelease logic.
routers/web/repo/release.go	Updates UI release creation to call new CreateRelease(ctx, ...) and removes pre-check for target branch existence.
routers/web/repo/branch.go	Refactors error handling and adds handling for invalid tag names.
routers/api/v1/repo/release.go	Updates API endpoint to call new CreateRelease(ctx, ...).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.