Add validation constraints for repository creation fields#36671
Add validation constraints for repository creation fields#36671lunny wants to merge 7 commits intogo-gitea:mainfrom
Conversation
GiteaBot
added
the
lgtm/need 2
|
Other fields like |
Only the |
These restrictions have been added to enforce stricter validation and prevent potential issues or unnecessary problems. |
There was a problem hiding this comment.
Pull request overview
This pull request adds input validation constraints to repository creation form fields and API options, limiting the size of various string fields to prevent potential issues with excessively long input values.
Changes:
- Added MaxSize validation to License (100), Gitignores (255), IssueLabels (255), Readme (255), and ForkSingleBranch (255) fields
- Added enum validation with In() to ObjectFormatName (sha1, sha256) and TrustModel (default, collaborator, committer, collaboratorcommitter) fields
- Applied validation consistently to both web form structs (CreateRepoForm) and API structs (CreateRepoOption)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| services/forms/repo_form.go | Added MaxSize and In() validation tags to CreateRepoForm fields for web form validation |
| modules/structs/repo.go | Added MaxSize and In() validation tags to CreateRepoOption fields for API validation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Update PR title please to reflect that it's not only license. |
lunny
changed the title
github-actions
bot
added
the
modifies/api
services/forms/repo_form.go
Outdated
| ForkSingleBranch string | ||
| ObjectFormatName string | ||
| ForkSingleBranch string `binding:"MaxSize(255)"` | ||
| ObjectFormatName string `binding:"In(sha1,sha256)"` |
There was a problem hiding this comment.
I don't think it's right
modules/structs/repo.go
Outdated
| // enum: default,collaborator,committer,collaboratorcommitter | ||
| TrustModel string `json:"trust_model"` | ||
| // ObjectFormatName of the underlying git repository | ||
| TrustModel string `json:"trust_model" binding:"In(default,collaborator,committer,collaboratorcommitter)"` |
|
Maybe add some tests to validate the new limits? Tests could be AI-generated. |
|
Unnecessary tests only slow down the tests. Incorrect tests slow down more. |
| Template bool `json:"template"` | ||
| // Gitignores to use | ||
| Gitignores string `json:"gitignores"` | ||
| Gitignores string `json:"gitignores" binding:"MaxSize(255)"` |
There was a problem hiding this comment.
Are you sure Gitignores should have MaxSize(255)? What wrong will happen if it exceeds?
5 participants
Adds validation constraints to repository creation inputs, enforcing max-length limits for labels/gitignores/license/readme and enum validation for trust model and object format. Updates both the API option struct and the web form struct to keep validation consistent.