Set default less and css to new default name#54
Set default less and css to new default name#54tboerger merged 3 commits intogo-gitea:masterfrom joubertredrat:changes-less-css
Conversation
Current coverage is 2.18% (diff: 100%)@@ master #54 diff @@
========================================
Files 31 31
Lines 7508 7508
Methods 0 0
Messages 0 0
Branches 0 0
========================================
Hits 164 164
Misses 7327 7327
Partials 17 17
|
public/css/index.css
Outdated
There was a problem hiding this comment.
Only unnecessary spaces was removed. selector continue with same definitions.
https://github.com/go-gitea/gitea/blob/master/public/css/gogs.css#L31
https://github.com/joubertredrat/gitea/blob/changes-less-css/public/css/index.css#L31
There was a problem hiding this comment.
But there are css changes, you just renamed the less file.
There was a problem hiding this comment.
@tboerger was my fault, If you see on PR gogs/gogs#3786, don't have empty lines on css, I don't know why, my npm display that less version is 2.7.1, but on my terminal was using 1.4.2. Now I solved this and generated correct css files, with no empty files and with !important as defined on less.
|
One minor change, otherwise LGTM after rebase. |
|
LGTM |
|
LGTM, Just need a rebase |
|
Done, with rebase |
|
LGTM |
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
tboerger
added
the
lgtm/done
6 participants
Remove mentions to Gogs on js, css and less files, generated with lessc 2.7.1