Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.

add some functionality#180

Open
mqy527 wants to merge 62 commits intogo-gota:masterfrom
mqy527:master
Open

add some functionality#180
mqy527 wants to merge 62 commits intogo-gota:masterfrom
mqy527:master

Conversation

@mqy527
Copy link

@mqy527 mqy527 commented Mar 9, 2022

add: series rolling, series calculation with number and another series、logical operation

Copy link
Contributor

@chrmang chrmang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a big PR with a lot of new functionality and breaking changes. Maybe we should open an issue to discuss your intention. Breaking changes need always some planning.


"github.com/go-gota/gota/dataframe"
"github.com/go-gota/gota/series"
"github.com/mqy527/gota/dataframe"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope, this is a mistake - keep go-gota here.

// New is the generic DataFrame constructor
func New(se ...series.Series) DataFrame {
if se == nil || len(se) == 0 {
if len(se) == 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants