Skip to content

refactor(lint/unconvert): remove base64 call returns a string #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
peterbourgon merged 3 commits into from
Jul 17, 2018
Merged

refactor(lint/unconvert): remove base64 call returns a string #717

peterbourgon merged 3 commits into from
Jul 17, 2018

Conversation

@mishudark
Copy link
Contributor

@mishudark mishudark commented Jun 8, 2018

currently base64.StdEncoding.EncodeToString returns an string, extra conversion is not necessary

peterbourgon
peterbourgon approved these changes Jul 16, 2018
View reviewed changes
Copy link
Member

@peterbourgon peterbourgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterbourgon peterbourgon merged commit af73865 into go-kit:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterbourgon peterbourgon peterbourgon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mishudark @peterbourgon