Skip to content

Conversation

@youzhixiaomutou
Copy link
Contributor

@youzhixiaomutou youzhixiaomutou commented Aug 23, 2024

Description (what this PR does / why we need it):

According to https://github.com/go-kratos/kratos/tree/main/contrib/config/nacos、https://github.com/go-kratos/kratos/tree/main/contrib/registry/nacos,kratos Nacos’ adaptor uses nacos-sdk-go v1.
It will cause some problems like:

  1. nacos-sdk-go v1 is not fully compatible with Nacos server v2.x. And Nacos server v2.x is the lts version for a long time(https://github.com/nacos-group/nacos-sdk-go/tree/v1.x-develop-support-naming-ak).
    image
  2. I use Nacos by MSE in alicloud. It clearly indicates that there are many features which are important is not support nacos-sdk-go v1.
    image
    image

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

  1. nacos-sdk-client v2 is supported Go version over 1.15 and Nacos server version over 2.x. So it should add a new v2 package for v1 compatibility.
  2. service subscribe callback is not working with nacos server v2.0.x、v2.1.x when clusters are set,it should upgrade nacos server to newest version(when set clusters for subscribe not trigger callback nacos-group/nacos-sdk-go#761).
  3. fix some unit tests with nacos-sdk-go v2.

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant