Move testing -> testr, deprecate, alias old names#140
Merged
pohly merged 1 commit intogo-logr:masterfrom Mar 17, 2022
Merged
Conversation
pohly
requested changes
Mar 16, 2022
Contributor
pohly
left a comment
pohly
left a comment
There was a problem hiding this comment.
Looks good to me. The new klog/ktesting just got released, so as you are touching that line I added a suggestion for it.
I'm also wondering about best practices for constructor function namining.
This avoids the pkg name overlap with standard "testing".
thockin
commented
Mar 16, 2022
Contributor
Author
thockin
left a comment
thockin
left a comment
There was a problem hiding this comment.
New push with changes is up! Thanks.
rollulus
approved these changes
Mar 17, 2022
rollulus
left a comment
rollulus
left a comment
There was a problem hiding this comment.
LGTM, thanks for this and thanks in general forlogr!
Contributor
Author
|
I tagged v1.2.3 with this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids the pkg name overlap with standard "testing".
Fixes #138