This repository was archived by the owner on Dec 30, 2025. It is now read-only.
[WIP] Update Parse method to skip parsing URIs#13
Open
panicpanicpanic wants to merge 2 commits intogo-shiori:masterfrom
Open
[WIP] Update Parse method to skip parsing URIs#13panicpanicpanic wants to merge 2 commits intogo-shiori:masterfrom
panicpanicpanic wants to merge 2 commits intogo-shiori:masterfrom
Conversation
added 2 commits
June 20, 2019 14:59
… not passed to the Parse method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces logic that allows parsing an input of
io.Readerwithout necessarily supplying apageURL. This allows some flexibility, as sometimes you might not want (or have access) to pass apageURL. To bypass, simple send a zero-valuedstring.This is still currently a WIP, as I figure out the best way to test this with the current test suite in place :)