This repository was archived by the owner on Dec 30, 2025. It is now read-only.
script/generate-test: add publishedTime, modifiedTime to expected metadata#97
Open
mislav wants to merge 1 commit intogo-shiori:masterfrom
Open
script/generate-test: add publishedTime, modifiedTime to expected metadata#97mislav wants to merge 1 commit intogo-shiori:masterfrom
mislav wants to merge 1 commit intogo-shiori:masterfrom
Conversation
…adata The `script/generate-test` script fetches a HTML page and stores its parse result as a test expectation. However, published & modified timestamps were not persisted, even when they were correctly extracted by readability. As a result, sometimes a generated test would immediately be failing, even if the readability implementation didn't change in the meantime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
script/generate-testscript fetches a HTML page and stores its parse result as a test expectation. However, published & modified timestamps were not persisted, even when they were correctly extracted by readability. As a result, sometimes a generated test would immediately be failing with a mismatch in these timestamps, even if the readability implementation didn't change in the meantime.