Skip to content

Conversation

@fmartingr
Copy link
Member

@fmartingr fmartingr commented Mar 15, 2025

  • Reverts back the responses of the API to be like {"ok": bool, "message": body}
  • Allows using the future response by setting the X-Shiori-Request-Format to new

This will be the default until 2.0 is released with the removal of the legacy API.

@fmartingr fmartingr added this to the 1.8.0 milestone Mar 15, 2025
@fmartingr fmartingr self-assigned this Mar 15, 2025
@codecov
Copy link

codecov bot commented Mar 15, 2025

Codecov Report

Attention: Patch coverage is 77.33333% with 17 lines in your changes missing coverage. Please review.

Project coverage is 50.08%. Comparing base (d419818) to head (d50a6bb).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/http/middleware/message_response.go 75.80% 10 Missing and 5 partials ⚠️
internal/http/webcontext/context.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1082      +/-   ##
==========================================
+ Coverage   49.68%   50.08%   +0.40%     
==========================================
  Files          73       74       +1     
  Lines        7320     7389      +69     
==========================================
+ Hits         3637     3701      +64     
  Misses       3366     3366              
- Partials      317      322       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fmartingr fmartingr merged commit 1f30946 into master Mar 16, 2025
17 checks passed
@fmartingr fmartingr deleted the fix/middleware-message branch March 16, 2025 18:09
@github-project-automation github-project-automation bot moved this to Done in Roadmap Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants