grpc/codegen: allow overriding proto json_name#3857
Merged
raphael merged 1 commit intogoadesign:v3from Dec 13, 2025
Merged
Conversation
Member
|
Looks great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Meta("proto:tag:json", ...)so designers can override thejson_nameemitted in generated protobuf definitionsgrpc/codegen/protobuf.go, emitting[json_name = "..."]on both regular fields and oneof members when presentMotivation
Some downstream consumers rely on protobuf JSON descriptors whose field names must diverge from the default lower_snake_case. Prior to this change there was no way to control the descriptor in Goa-generated protos without patching the generated files. The new metadata brings parity with the existing struct-tag overrides and keeps designs self-contained.
Example
DSL:
Generated
.protofragmentGenerated Go struct (
.pb.go)