http: preserve Content-Type parameters set in DSL (fixes #3843)#3860
Merged
http: preserve Content-Type parameters set in DSL (fixes #3843)#3860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3843.
When
ContentType(...)is explicitly set in the DSL,ResponseEncoderparsed it to infer the encoder, but then overwrote the response header with the parsed media type, dropping parameters likecharset.This change keeps using the parsed media type for encoder selection, but sets the header using the original DSL value, preserving parameters.
Added a unit test asserting the
charsetparameter is preserved.