Proposal: confusion on the eager on connection and function behaviors

[sio4]

Hi @mclark4386, @stanislas-m, and all!

I wonder following behaviors:

Query.Clone() does not copy eager and eagerFields. Is it desired action?

pop/query.go

Lines 29 to 54 in 53115b9

	// Clone will fill targetQ query with the connection used in q, if
	// targetQ is not empty, Clone will override all the fields.
	func (q *Query) Clone(targetQ *Query) {
	rawSQL := *q.RawSQL
	targetQ.RawSQL = &rawSQL
	targetQ.limitResults = q.limitResults
	targetQ.whereClauses = q.whereClauses
	targetQ.orderClauses = q.orderClauses
	targetQ.fromClauses = q.fromClauses
	targetQ.belongsToThroughClauses = q.belongsToThroughClauses
	targetQ.joinClauses = q.joinClauses
	targetQ.groupClauses = q.groupClauses
	targetQ.havingClauses = q.havingClauses
	targetQ.addColumns = q.addColumns
	if q.Paginator != nil {
	paginator := *q.Paginator
	targetQ.Paginator = &paginator
	}
	if q.Connection != nil {
	connection := *q.Connection
	targetQ.Connection = &connection
	}
	}

I tried to do something like following before I looking in it:

normalQuery := tx.Eager("A").Eager("B").Where("some = true")
specialQuery := &pop.Query{}
normalQuery.Clone(specialQuery) // eager information is not copied
specialQuery = specialQuery.Where("")

It does not work as I imagine. I think Clone() should copy everything.

But for Q(Connection), it copies eager and eagerFields even though the comment said it will create a new "empty" query.

pop/query.go

Lines 178 to 186 in 53115b9

	// Q will create a new "empty" query from the current connection.
	func Q(c *Connection) *Query {
	return &Query{
	RawSQL: &clause{},
	Connection: c,
	eager: c.eager,
	eagerFields: c.eagerFields,
	}
	}

I know, when we call Connection.Where(...), it internally do Q(c) and we can get query with earger information without further action. So I can improve my routine like below:

normalQuery := tx.Eager("A").Eager("B").Where("some = true")
specialQuery := pop.Q(normalQuery.Connection)
normalQuery.Clone(specialQuery) // eager information is not copied
specialQuery = specialQuery.Where("")

But this code is not smoothly read.

When I found this sequence at the first time, I wonder why Connection has eager and eagerFields but now I found it is required for the eager version of executors. But I feel it makes some confusion and I just thought about:

• if we add another structure something like Eager and
• Connection.Eager() returns Eager instead of NEW Connection and
• add Eager.Where() wrapper and Eager.Create() wrapper, and so on,...

Then, can we keep the structure more simple?

I know there are busy actions on the eager implementation recently. Can you consider above confusion and idea?