fixed concurrent map write issue on ConnectionDetails.Options (#577)#785
Merged
fixed concurrent map write issue on ConnectionDetails.Options (#577)#785
Conversation
sio4
commented
Sep 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indeed, the map
ConnectionDetails.Optionsis not protected on write accesses. This PR adds a setter and getter for the map, and the setter uses a mutex lock to protect them. However, the CD operations only happen when the connection is defined and configured so I am not sure how they are accessed concurrently. 🤔fixes #577