Fix Bug: retry scrape will lost POST requestData#794
Merged
WGH- merged 1 commit intogocolly:masterfrom Mar 25, 2024
Merged
Conversation
Contributor
Author
WGH-
requested changes
Mar 14, 2024
Collaborator
WGH-
left a comment
There was a problem hiding this comment.
I don't think it's a good idea to limit the API to seekable bodies.
However, we might try to rewind the body if it happens to implement io.Seeker. And it might be a good idea to make Retry retry an error if doesn't.
Contributor
Author
是个好主意
|
WGH-
reviewed
Mar 25, 2024
Collaborator
|
Otherwise, looks good |
When calling Request.Retry, and request has a body (e.g. POST form or file upload), try to rewind it. If it's not seekable, return ErrRetryBodyUnSeekable error.
WGH-
approved these changes
Mar 25, 2024
Collaborator
|
And thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when retry scrape
requestData will loss in http.NewRequest
so Seek requestData before scrape.NewRequest