[3.x] When a gamepad is disconnected, input actions are left active

[fractilegames]

Tested versions

Found in Godot v3.6-stable x11.64

System information

Xubuntu 24.04

Issue description

When a gamepad is disconnected, any active input actions with JoyAxis events remain active indefinitely.

I tested this using PS3 and PS4 controllers with wired connection. The engine sees the gamepad disconnection and joy_connection_changed signal is emitted as expected. Gamepad works normally after reconnection.

Steps to reproduce

• Set up an input action with JoyAxis event
• Run project with a gamepad connected
• Deflect a gamepad stick to activate the action and disconnect the gamepad with the stick deflected.

=> The action will stay active (for example Input.get_action_strength() returns 1.0)

Minimal reproduction project (MRP)

GamepadDisconnectTest.zip

[orlambda]

I've replicated this on macOS 14.4.1 with a PS5 controller, wired.

Input.get_action_strength() returns 1 after the controller is disconnected regardless of whether the joystick is deflected at that point. So even if it's outputting 0, it will start outputting 1 when the controller is disconnected.

I'm happy to work on this.

[orlambda]

It looks like what I'm observing on macOS 14 is related but different so I'll probably create a new issue for that when I can define it more precisely. It may be that one fix covers both these cases. The exact behaviour varies with different operating systems and controllers, so this could do with being tested on a variety of platforms.

I think I'm close to a fix. I'll post more soon when I have a clearer understanding.

[MJacred]

Can confirm this issue in 3.6 with XBox 360 joypad on Ubuntu and that Godot 4.4.1 works fine (I checked action strength in _process()

[rxlecky]

Seeing that this issue seems platform/controller-dependent, I wanted to chip in with test results from Windows, using various Godot versions and controllers:

	Xbox One Controller	PS5 Controller
Godot 3.6	Correct behaviour	Bug
Godot 4.2.2	Correct behaviour	Bug
Godot 4.4.1	Correct behaviour	Correct behaviour

It seems that the bug got fixed on Godot 4 somewhere between 4.2.2 and 4.4.1 and it only needs to be fixed on 3.x.

Also, the difference in behaviour between Xbox and PS controllers on Windows appears to be coming from the different underlying library being used for polling for events (XInput vs DInput).

[Nintorch]

Hello! May I ask if the issue is reproducible in Godot 4.6? In Godot 4.5 we switched to using SDL, and now there's a PR to switch Godot 3.x to SDL: #110013