Skip to content

Physics Interpolation - Fix project setting tooltip#104525

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
lawnjelly:fti_fix_proj_setting_doc
Mar 28, 2025
Merged

Physics Interpolation - Fix project setting tooltip#104525
akien-mga merged 1 commit intogodotengine:masterfrom
lawnjelly:fti_fix_proj_setting_doc

Conversation

@lawnjelly
Copy link
Copy Markdown
Member

@lawnjelly lawnjelly commented Mar 23, 2025

Corrects a confusing documentation which refers to physics objects, whereas FTI applies to all rendered objects.

Fixes tooltip documentation mentioned in #104423

Bugsquad edit: Closes #104423.

Notes

  • Also removes the jitter fix section which is now out of date (it gets set to 0.0 automatically at startup when physics interpolation is on).

@Mickeon
Copy link
Copy Markdown
Member

Mickeon commented Mar 23, 2025

it gets set to 0.0 automatically at startup when physics interpolation is on).

Then that's exactly what should be said, instead.

Also this description is duplicated in SceneTree's physics_interpolation property, so it should be changed there as well

@lawnjelly lawnjelly force-pushed the fti_fix_proj_setting_doc branch from 7cf04ed to 756fb89 Compare March 24, 2025 06:19
@lawnjelly
Copy link
Copy Markdown
Member Author

Then that's exactly what should be said, instead.
Also this description is duplicated in SceneTree's physics_interpolation property, so it should be changed there as well

Done. I've also expanded the section into a note on physics_interpolation_mode as it makes sense to make it clear here that the global setting can be overridden per branch, this is not obvious to a lot of users.

@lawnjelly lawnjelly added the cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release label Mar 24, 2025
@lawnjelly lawnjelly force-pushed the fti_fix_proj_setting_doc branch from 756fb89 to 93149bc Compare March 24, 2025 09:17
Corrects a confusing documentation which refers to physics objects, whereas FTI applies to all rendered objects.
@lawnjelly lawnjelly force-pushed the fti_fix_proj_setting_doc branch from 93149bc to 407ab87 Compare March 24, 2025 11:23
Copy link
Copy Markdown
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not deep into physics, but if the physics contributors needs a review I approve.

@akien-mga akien-mga merged commit b0ede90 into godotengine:master Mar 28, 2025
20 checks passed
@akien-mga
Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Physics interpolation affects particle systems

5 participants